diff options
| author | Rich Trott <rtrott@gmail.com> | 2016-10-12 21:34:44 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2016-10-19 08:35:15 -0700 |
| commit | add885416f38020f84b544b3cc0be28d6cf59bdc (patch) | |
| tree | eddd50f77076eabe301b20339a07684d66b11b81 /doc/onboarding.md | |
| parent | 92ece8671a3da8910bc8755b16ac121ba300a122 (diff) | |
| download | android-node-v8-add885416f38020f84b544b3cc0be28d6cf59bdc.tar.gz android-node-v8-add885416f38020f84b544b3cc0be28d6cf59bdc.tar.bz2 android-node-v8-add885416f38020f84b544b3cc0be28d6cf59bdc.zip | |
doc: add ctc-review label information
PR-URL: https://github.com/nodejs/node/pull/9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index e22c876893..5d0560e176 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -62,7 +62,8 @@ onboarding session. * Labels: * There is [a bot](https://github.com/nodejs-github-bot/github-bot) that applies subsystem labels (for example, `doc`, `test`, `assert`, or `buffer`) so that we know what parts of the code base the pull request modifies. It is not perfect, of course. Feel free to apply relevant labels and remove irrelevant labels from pull requests and issues. * [**See "Labels"**](./onboarding-extras.md#labels) - * Use the `ctc-agenda` if a topic is controversial or isn't coming to a conclusion after an extended time. + * Use the `ctc-review` label if a topic is controversial or isn't coming to + a conclusion after an extended time. * `semver-{minor,major}`: * If a change has the remote *chance* of breaking something, use `semver-major` * When adding a semver label, add a comment explaining why you're adding it. Do it right away so you don't forget! @@ -145,7 +146,8 @@ onboarding session. the objection is addressed. The options for such a situation include: * Engaging those with objections to determine a viable path forward; * Altering the pull request to address the objections; - * Escalating the discussion to the CTC using the `ctc-agenda` label. This should only be done after other options have been exhausted. + * Escalating the discussion to the CTC using the `ctc-review` label. This + should only be done after the previous options have been exhausted. * Wait before merging non-trivial changes. * 48 hours during the week and 72 hours on weekends. |