diff options
| author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-07-26 00:37:57 +0300 |
|---|---|---|
| committer | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-07-26 18:01:31 +0300 |
| commit | a9f32a31e2c32de0f62f107ca5d4ac914bb70ccf (patch) | |
| tree | 9a1747ab9a9b3044c3060fb6015cd21fe1813e4a /doc/onboarding.md | |
| parent | 36a15a1f4df534941e002d10a45661b36909af3d (diff) | |
| download | android-node-v8-a9f32a31e2c32de0f62f107ca5d4ac914bb70ccf.tar.gz android-node-v8-a9f32a31e2c32de0f62f107ca5d4ac914bb70ccf.tar.bz2 android-node-v8-a9f32a31e2c32de0f62f107ca5d4ac914bb70ccf.zip | |
doc: do not advise to cancel full CI on onboarding
Refs: https://github.com/nodejs/node/pull/21938#discussion_r204257281
and discussion below the comment.
PR-URL: https://github.com/nodejs/node/pull/21977
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index b6464ebae4..3a03edb17e 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -213,9 +213,7 @@ needs to be pointed out separately during the onboarding. * Optionally, include your personal pronouns. * Label your pull request with the `doc` and `notable-change` labels. * Run CI on the PR. Because the PR does not affect any code, use the - `node-test-pull-request-lite-pipeline` CI task. Alternatively, use the usual - `node-test-pull-request` CI task and cancel it after the linter and one other - subtask have passed. + `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait for 48/72 hours to land). * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` |