diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-06-20 13:25:25 -0600 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-23 07:07:14 -0700 |
| commit | 73d22d14340d2846f502e5d85958c41f903ed878 (patch) | |
| tree | ef8dc4a04e11db3d338fc39a93761ee59227f1a1 /doc/onboarding.md | |
| parent | 00907980f0599d892a12082a8f9ec1636ed7e641 (diff) | |
| download | android-node-v8-73d22d14340d2846f502e5d85958c41f903ed878.tar.gz android-node-v8-73d22d14340d2846f502e5d85958c41f903ed878.tar.bz2 android-node-v8-73d22d14340d2846f502e5d85958c41f903ed878.zip | |
doc: remove "make that" from onboarding.md
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/16
PR-URL: https://github.com/nodejs/node/pull/28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index b8b6ee6233..860e573790 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -124,7 +124,7 @@ onboarding session. * Be aware: Your opinion carries a lot of weight! * Nits (requests for small changes that are not essential) are fine, but try to avoid stalling the pull request. - * Note that they are nits when you comment: `Nit: change foo() to bar().` + * Identify them as nits when you comment: `Nit: change foo() to bar().` * If they are stalling the pull request, fix them yourself on merge. * Insofar as possible, issues should be identified by tools rather than human reviewers. If you are leaving comments about issues that could be identified @@ -191,7 +191,7 @@ onboarding session. See the Collaborator Guide: [Landing Pull Requests][]. -Note that commits in one PR that belong to one logical change should +Commits in one PR that belong to one logical change should be squashed. It is rarely the case in onboarding exercises, so this needs to be pointed out separately during the onboarding. |