diff options
| author | Rich Trott <rtrott@gmail.com> | 2016-09-13 20:48:59 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2016-09-15 21:57:14 -0700 |
| commit | 54dc719663da0378dafa17e8507f9c209d1ffdea (patch) | |
| tree | d61134ba520d8269c3655fa7d20f5e053187c519 /doc/onboarding.md | |
| parent | a01c365193afc0c05b7181aae9ecd753de001865 (diff) | |
| download | android-node-v8-54dc719663da0378dafa17e8507f9c209d1ffdea.tar.gz android-node-v8-54dc719663da0378dafa17e8507f9c209d1ffdea.tar.bz2 android-node-v8-54dc719663da0378dafa17e8507f9c209d1ffdea.zip | |
doc: link onboarding to contributing guide
Replace the description of the commit message requirements in
onboarding.md with a link to the commit message requirements as they
appear in the CONTRIBUTING.md.
Advantages include:
* Only one place to keep the commit message requirements up to date
* Most collaborators being onboarded will already have several commits
in their name and already be familiar with the requirements. So
repeating information here makes finding the new information (about
metadata, for example) harder to find.
PR-URL: https://github.com/nodejs/node/pull/8529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index e1c1a5dca4..f554d5f010 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -165,15 +165,13 @@ Update your `master` branch (or whichever branch you are landing on, almost alwa Landing a PR -* if it all looks good, `curl -L 'url-of-pr.patch' | git am` +* If it all looks good, `curl -L 'url-of-pr.patch' | git am` * If `git am` fails, see [the relevant section of the Onboarding Extras doc](./onboarding-extras.md#if-git-am-fails). * `git rebase -i upstream/master` -* squash into logical commits if necessary +* Squash into logical commits if necessary. * `./configure && make -j8 test` (`-j8` builds node in parallel with 8 threads. adjust to the number of cores (or processor-level threads) your processor has (or slightly more) for best results.) * Amend the commit description. - * Commits should be of the form `subsystem[,subsystem]: small description\n\nbig description\n\n<metadata>` - * The first line should not exceed 50 characters. - * The remaining lines (except for metadata lines) should wrap at 72 characters. + * The commit message text must conform to the [commit message guidelines](../CONTRIBUTING.md#step-3-commit). * Add required metadata: * `PR-URL: <full-pr-url>` * `Reviewed-By: <collaborator name> <collaborator email>` |