diff options
| author | Rich Trott <rtrott@gmail.com> | 2016-09-15 22:50:28 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2016-09-18 21:38:49 -0700 |
| commit | 4c7688138366bc350ed0260583d457733f835828 (patch) | |
| tree | 6006129541ea2a75aa617bc2a7162a64f221214b /doc/onboarding.md | |
| parent | 30701a72c04d72d31ab5de8f0003d8ec460928a8 (diff) | |
| download | android-node-v8-4c7688138366bc350ed0260583d457733f835828.tar.gz android-node-v8-4c7688138366bc350ed0260583d457733f835828.tar.bz2 android-node-v8-4c7688138366bc350ed0260583d457733f835828.zip | |
doc: update exercise portion of onboarding doc
PR-URL: https://github.com/nodejs/node/pull/8559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index f554d5f010..3b0af6b474 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -188,14 +188,15 @@ Landing a PR * Close the pull request with a "Landed in `<commit hash>`" comment. -## exercise: make PRs adding yourselves to the README +## Exercise: Make a PR adding yourself to the README * Example: https://github.com/nodejs/node/commit/7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 - * to see full URL: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1` - * Collaborators in alphabetical order by username - * Label your pull request with the `doc` subsystem label - * If you would like to run CI on your PR, feel free to - * Make sure to added the `PR-URL: <full-pr-url>`! + * For raw commit message: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1` + * Collaborators are in alphabetical order by GitHub username. + * Label your pull request with the `doc` subsystem label. + * Run CI on your PR. + * After a `LGTM` or two, land the PR. + * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata! ## final notes |