diff options
| author | Ouyang Yadong <oyydoibh@gmail.com> | 2018-09-30 18:17:36 +0800 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-10-04 14:51:02 -0700 |
| commit | 26af72899417525dd32372d63c07ee5aa1ab6c5c (patch) | |
| tree | 0effe53f03127f80998733507adb88fdf8399f4b /doc/onboarding.md | |
| parent | 6f7fd7f9bc743f7244f820a1b7be1e01562c96fd (diff) | |
| download | android-node-v8-26af72899417525dd32372d63c07ee5aa1ab6c5c.tar.gz android-node-v8-26af72899417525dd32372d63c07ee5aa1ab6c5c.tar.bz2 android-node-v8-26af72899417525dd32372d63c07ee5aa1ab6c5c.zip | |
dns: deprecate passing falsy hostname to dns.lookup
We can `dns.lookup` a falsy `hostname` like `dns.lookup(false)`
for the reason of backwards compatibility long before(see #13119
for detail). This behavior is undocumented and seems useless in
real world apps.
We could also make invalid `hostname` throw in the future and the
change might be semver-major.
Fixes: https://github.com/nodejs/node/issues/13119
PR-URL: https://github.com/nodejs/node/pull/23173
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'doc/onboarding.md')
0 files changed, 0 insertions, 0 deletions