diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-09-25 06:35:33 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-10-06 15:32:51 -0700 |
| commit | 124a8e21238f8452028614625fe491b3049f7244 (patch) | |
| tree | 52f702497f8984b4e14b247f4ef166b7bf50d518 /doc/onboarding.md | |
| parent | 004f8b037e8e89987dbbe6314ba0ddf45d6719b4 (diff) | |
| download | android-node-v8-124a8e21238f8452028614625fe491b3049f7244.tar.gz android-node-v8-124a8e21238f8452028614625fe491b3049f7244.tar.bz2 android-node-v8-124a8e21238f8452028614625fe491b3049f7244.zip | |
doc: shorten pull request wait time to 48 hours
Currently, we have a 72 rule for how many hours a pull request should
be left open at a minimum. Reduce that time to 48 hours.
PR-URL: https://github.com/nodejs/node/pull/23082
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index bd9418fd91..ef7f328a31 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -138,7 +138,7 @@ onboarding session. * There is a minimum waiting time which we try to respect for non-trivial changes so that people who may have important input in such a distributed project are able to respond. - * For non-trivial changes, leave the pull request open for at least 72 hours. + * For non-trivial changes, leave the pull request open for at least 48 hours. * If a pull request is abandoned, check if they'd mind if you took it over (especially if it just has nits left). * Approving a change @@ -214,7 +214,7 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait - for 72 hours to land). + for 48 hours to land). * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing |