diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-10-06 15:36:08 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-10-06 21:29:27 -0700 |
| commit | 061e09891cd5115641b5c3199a5f457b519ec77b (patch) | |
| tree | e5c7905a6dc2fd7a9d48c51e1f312f2be54a84ef /doc/onboarding.md | |
| parent | f4235794981fa71f700e04d88d4cab015fc0143b (diff) | |
| download | android-node-v8-061e09891cd5115641b5c3199a5f457b519ec77b.tar.gz android-node-v8-061e09891cd5115641b5c3199a5f457b519ec77b.tar.bz2 android-node-v8-061e09891cd5115641b5c3199a5f457b519ec77b.zip | |
doc: update onboarding task
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.
PR-URL: https://github.com/nodejs/node/pull/23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index ef7f328a31..0c46318a78 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -210,11 +210,12 @@ needs to be pointed out separately during the onboarding. -1` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. -* Label your pull request with the `doc` and `notable-change` labels. +* Label your pull request with the `doc`, `notable-change`, and `fast-track` + labels. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. -* After one or two approvals, land the PR (PRs of this type do not need to wait - for 48 hours to land). +* After two Collaborator approvals for the change and two Collaborator approvals + for fast-tracking, land the PR. * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing |