diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-04-29 20:37:19 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-05-02 19:16:07 -0700 |
| commit | ac6d1f20b9668d5f904d9e592bfd0ae0bfd3445e (patch) | |
| tree | 102f8244f4cc2f82cbf1310944015771840e0a69 /doc/onboarding-extras.md | |
| parent | 7588ceaf353af0f257d4d832bace4600edac704e (diff) | |
| download | android-node-v8-ac6d1f20b9668d5f904d9e592bfd0ae0bfd3445e.tar.gz android-node-v8-ac6d1f20b9668d5f904d9e592bfd0ae0bfd3445e.tar.bz2 android-node-v8-ac6d1f20b9668d5f904d9e592bfd0ae0bfd3445e.zip | |
doc: remove squash guideline from onboarding doc
Although I agree with the guideline people should generally not squash
commits in a pull request until the end (in other words, until it's time
to land the PR), it is clear from comments and actions in the issue
tracker that many do not share that view. This is fine by me, but I do
think that we should our documentation should reflect our practices
rather than being an aspirational statement.
If we *do* wish to preserve this recommendation, it probably belongs in
another document anyway as this is not a recommendation for
Collaborators only but for anyone opening a pull request.
PR-URL: https://github.com/nodejs/node/pull/20413
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc/onboarding-extras.md')
| -rw-r--r-- | doc/onboarding-extras.md | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index ffc316d7a6..62a7f7bb6b 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -97,4 +97,3 @@ to update from nodejs/node: ## Best practices * When making PRs, spend time writing a thorough description. -* Usually only squash at the end of your work. |