diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-05-29 19:59:28 -0700 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-06-01 12:47:26 +0200 |
| commit | 7dca3297bce9c19a0451be1b130c8fcab564fe04 (patch) | |
| tree | bd1bed23e948bc8575e96a509db8a3109dfdbd48 /doc/onboarding-extras.md | |
| parent | df16d20f7569f6538eb6558ea63c614e3b139abc (diff) | |
| download | android-node-v8-7dca3297bce9c19a0451be1b130c8fcab564fe04.tar.gz android-node-v8-7dca3297bce9c19a0451be1b130c8fcab564fe04.tar.bz2 android-node-v8-7dca3297bce9c19a0451be1b130c8fcab564fe04.zip | |
doc: remove vestigial onboarding section
The onboarding-extras doc includes a section with a single bullet point
instructing the new Collaborator to write good pull request
descriptions. This material is likely superfluous and is in the wrong
document if it is not. (It more properly belongs in pull-requests.md as
it is information that is not specific to new Collaborators.) I am not
putting it in pullrequests.md because that document is already plenty
long and detailed, and includes advice on writing good commit messages,
which tend to become the pull request descriptions anyway.
PR-URL: https://github.com/nodejs/node/pull/21028
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'doc/onboarding-extras.md')
| -rw-r--r-- | doc/onboarding-extras.md | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 62a7f7bb6b..74317c7e2b 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -93,7 +93,3 @@ to update from nodejs/node: * `git checkout master` * `git remote update -p` OR `git fetch --all` * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`) - -## Best practices - -* When making PRs, spend time writing a thorough description. |