summaryrefslogtreecommitdiff
path: root/doc/onboarding-extras.md
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2017-12-17 20:32:28 -0300
committerRuben Bridgewater <ruben@bridgewater.de>2017-12-26 10:41:17 +0100
commit6924dac6cef7a0eae661903a17b1d35e22166c27 (patch)
tree1a330a54757f1521f2a86cea363a8f0ca0f40d9f /doc/onboarding-extras.md
parent5c2901391a656a5c3b931590e39a9c182b7aecd3 (diff)
downloadandroid-node-v8-6924dac6cef7a0eae661903a17b1d35e22166c27.tar.gz
android-node-v8-6924dac6cef7a0eae661903a17b1d35e22166c27.tar.bz2
android-node-v8-6924dac6cef7a0eae661903a17b1d35e22166c27.zip
doc: use consistent new lines
PR-URL: https://github.com/nodejs/node/pull/17722 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'doc/onboarding-extras.md')
-rw-r--r--doc/onboarding-extras.md4
1 files changed, 0 insertions, 4 deletions
diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md
index a010d8fef1..9b00b2cecf 100644
--- a/doc/onboarding-extras.md
+++ b/doc/onboarding-extras.md
@@ -47,7 +47,6 @@ When things need extra attention, are controversial, or `semver-major`:
If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
-
## Labels
### By Subsystem
@@ -64,7 +63,6 @@ part(s) of the codebase it touches.
There may be more than one subsystem valid for any particular issue / PR.
-
### General
Please use these when possible / appropriate
@@ -136,7 +134,6 @@ need to be attached anymore, as only important bugfixes will be included.
* `arm`, `mips`, `s390`, `ppc`
* No x86{_64}, since that is the implied default
-
## Updating Node.js from Upstream
* `git remote add upstream git://github.com/nodejs/node.git`
@@ -147,7 +144,6 @@ to update from nodejs/node:
* `git remote update -p` OR `git fetch --all` (I prefer the former)
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
-
## best practices
* commit often, out to your github fork (origin), open a PR