diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-03-12 22:03:19 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-03-14 22:38:15 -0700 |
| commit | 536190f1747a1085c2dd208d0eed090f5ee32da0 (patch) | |
| tree | 30934c8db40b18b7bc6808a2dea4c5351aec9178 /doc/onboarding-extras.md | |
| parent | e5e0f9f3a839e261faa6dc3e2c4fedcd46bef5f4 (diff) | |
| download | android-node-v8-536190f1747a1085c2dd208d0eed090f5ee32da0.tar.gz android-node-v8-536190f1747a1085c2dd208d0eed090f5ee32da0.tar.bz2 android-node-v8-536190f1747a1085c2dd208d0eed090f5ee32da0.zip | |
doc: improve best practices in onboarding-extras
PR-URL: https://github.com/nodejs/node/pull/19315
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'doc/onboarding-extras.md')
| -rw-r--r-- | doc/onboarding-extras.md | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index 1a39b5acae..2bbf295783 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -142,10 +142,7 @@ to update from nodejs/node: * `git remote update -p` OR `git fetch --all` (I prefer the former) * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`) -## best practices +## Best practices -* commit often, out to your github fork (origin), open a PR -* when making PRs make sure to spend time on the description: - * every moment you spend writing a good description quarters the amount of - time it takes to understand your code. -* usually prefer to only squash at the *end* of your work, depends on the change +* When making PRs, spend time writing a thorough description. +* Usually only squash at the end of your work. |