diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-03-03 22:02:55 -0800 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-03-06 09:32:08 +0100 |
| commit | fe8d4a7ea7eeef21b25df4c5059a9e4e15b004c9 (patch) | |
| tree | 6760776136d1bfc3f9bb27a5b908eb86ef44826a /doc/guides/contributing/pull-requests.md | |
| parent | f05eaa4a537ed7ef57814d951d64c25ef2844720 (diff) | |
| download | android-node-v8-fe8d4a7ea7eeef21b25df4c5059a9e4e15b004c9.tar.gz android-node-v8-fe8d4a7ea7eeef21b25df4c5059a9e4e15b004c9.tar.bz2 android-node-v8-fe8d4a7ea7eeef21b25df4c5059a9e4e15b004c9.zip | |
doc: remove tentativeness in pull-requests.md
There are some uses of "in general" that are unnecessary. (We don't need
to be tentative about the fact that tests should pass, for example.)
PR-URL: https://github.com/nodejs/node/pull/19123
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc/guides/contributing/pull-requests.md')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index b80fe687ef..9220ab4e8e 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -401,10 +401,10 @@ seem unfamiliar, refer to this All Pull Requests require "sign off" in order to land. Whenever a contributor reviews a Pull Request they may find specific details that they would like to see changed or fixed. These may be as simple as fixing a typo, or may involve -substantive changes to the code you have written. In general, such requests -are intended to be helpful, but at times may come across as abrupt or unhelpful, -especially requests to change things that do not include concrete suggestions -on *how* to change them. +substantive changes to the code you have written. While such requests are +intended to be helpful, they may come across as abrupt or unhelpful, especially +requests to change things that do not include concrete suggestions on *how* to +change them. Try not to be discouraged. If you feel that a particular review is unfair, say so, or contact one of the other contributors in the project and seek their @@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page. For the size of "one logical change", [0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8) can be a good example. It touches the implementation, the documentation, -and the tests, but is still one logical change. In general, the tests should -always pass when each individual commit lands on the master branch. +and the tests, but is still one logical change. All tests should always pass +when each individual commit lands on the master branch. ### Getting Approvals for Your Pull Request |