diff options
author | Rich Trott <rtrott@gmail.com> | 2019-03-22 14:51:19 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-03-24 14:59:14 -0700 |
commit | 4ba33c90c6c50f625e071301f1ad4ba256d28246 (patch) | |
tree | 294de74c3290f1a3eb3f702ccb61bff40ce1d2a1 /doc/api/worker_threads.md | |
parent | 26f8af9feba624c418be1ec270c8de30bf6ee512 (diff) | |
download | android-node-v8-4ba33c90c6c50f625e071301f1ad4ba256d28246.tar.gz android-node-v8-4ba33c90c6c50f625e071301f1ad4ba256d28246.tar.bz2 android-node-v8-4ba33c90c6c50f625e071301f1ad4ba256d28246.zip |
test: delete pummel/test-dtrace-jsstack
The test pummel/test-dtrace-jsstack is broken and probably has been for
a very long time. Remove it.
It gets skipped on anything that is non-SunOS. In our CI, that means
skipped everywhere but SmartOS.
When run on SmartOS in our CI (which never happens because it's in
pummel, but I moved it into sequential to test it), it fails because it
needs elevated privileges.
When I log into the SmartOS machine and run the test as root, it fails
with:
AssertionError [ERR_ASSERTION]: did not find expected frame stalloogle
Since I have dtrace installed on my macOS machine, I tried running it
locally but removing the SunOS check. It failed because the test leaks a
global variable. I removed the global leak check, and the test failed
because I have System Integrity Protection enabled.
In short, the test does not work in its current form, has almost
certainly not worked in a long time, and is very likely to be brittle if
we ever do fix it. I'm inclined to remove it.
PR-URL: https://github.com/nodejs/node/pull/26869
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'doc/api/worker_threads.md')
0 files changed, 0 insertions, 0 deletions