diff options
author | Christopher Hiller <boneskull@boneskull.com> | 2019-07-10 13:27:44 -0700 |
---|---|---|
committer | Christopher Hiller <boneskull@boneskull.com> | 2019-07-12 14:48:09 -0700 |
commit | bff7a46f31f1da259071a1f4bd51aca726d5926e (patch) | |
tree | 16b62a84d9cc3ad1b5893bbb1d7039df066557ea /doc/api/process.md | |
parent | 28e18cfff0d491e14889935a64395cbbb5b666a6 (diff) | |
download | android-node-v8-bff7a46f31f1da259071a1f4bd51aca726d5926e.tar.gz android-node-v8-bff7a46f31f1da259071a1f4bd51aca726d5926e.tar.bz2 android-node-v8-bff7a46f31f1da259071a1f4bd51aca726d5926e.zip |
report: modify getReport() to return an Object
It's likely that anyone using `process.report.getReport()` will be
processing the return value thereafter (e.g., filtering fields or
redacting secrets). This change eliminates boilerplate by calling
`JSON.parse()` on the return value.
Also modified the `validateContent()` and `validate()` test helpers in
`test/common/report.js` to be somewhat more obvious and helpful. Of
note, a report failing validation will now be easier (though still not
_easy_) to read when prepended to the stack trace.
- Refs: https://github.com/nodejs/diagnostics/issues/315
PR-URL: https://github.com/nodejs/node/pull/28630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'doc/api/process.md')
-rw-r--r-- | doc/api/process.md | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/doc/api/process.md b/doc/api/process.md index 9bf2b7dc23..c5833e5bf4 100644 --- a/doc/api/process.md +++ b/doc/api/process.md @@ -1726,14 +1726,19 @@ added: v11.8.0 --> * `err` {Error} A custom error used for reporting the JavaScript stack. -* Returns: {string} +* Returns: {Object} -Returns a JSON-formatted diagnostic report for the running process. The report's -JavaScript stack trace is taken from `err`, if present. +Returns a JavaScript Object representation of a diagnostic report for the +running process. The report's JavaScript stack trace is taken from `err`, if +present. ```js const data = process.report.getReport(); -console.log(data); +console.log(data.header.nodeJsVersion); + +// Similar to process.report.writeReport() +const fs = require('fs'); +fs.writeFileSync(util.inspect(data), 'my-report.log', 'utf8'); ``` Additional documentation is available in the [report documentation][]. |