diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-02-14 00:18:18 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-03-15 12:53:22 +0100 |
| commit | 12b9ec09b0807a0b362986c80d3c4b9a644c611e (patch) | |
| tree | 86f4cf080cbcc33e8c8920b2ceb58514c1bd51f0 /doc/api/http2.md | |
| parent | 1eb6b01fca598194f59f8f4cac499825e6769363 (diff) | |
| download | android-node-v8-12b9ec09b0807a0b362986c80d3c4b9a644c611e.tar.gz android-node-v8-12b9ec09b0807a0b362986c80d3c4b9a644c611e.tar.bz2 android-node-v8-12b9ec09b0807a0b362986c80d3c4b9a644c611e.zip | |
http2: remove regular-file-only restriction
Requiring `respondWithFile()` to only work with regular files
is an artificial restriction on Node’s side and has become unnecessary.
Offsets or lengths cannot be specified for those files,
but that is an inherent property of other file types.
PR-URL: https://github.com/nodejs/node/pull/18936
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'doc/api/http2.md')
| -rw-r--r-- | doc/api/http2.md | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/doc/api/http2.md b/doc/api/http2.md index 94f25377d0..13aa4d1e21 100644 --- a/doc/api/http2.md +++ b/doc/api/http2.md @@ -1223,6 +1223,11 @@ if the `getTrailers` callback attempts to set such header fields. #### http2stream.respondWithFD(fd[, headers[, options]]) <!-- YAML added: v8.4.0 +changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/18936 + description: Any readable file descriptor, not necessarily for a + regular file, is supported now. --> * `fd` {number} A readable file descriptor. @@ -1313,6 +1318,11 @@ if the `getTrailers` callback attempts to set such header fields. #### http2stream.respondWithFile(path[, headers[, options]]) <!-- YAML added: v8.4.0 +changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/18936 + description: Any readable file, not necessarily a + regular file, is supported now. --> * `path` {string|Buffer|URL} |