summaryrefslogtreecommitdiff
path: root/doc/api/deprecations.md
diff options
context:
space:
mode:
authorRodger Combs <rodger.combs@gmail.com>2018-01-12 17:36:21 -0600
committerOuyang Yadong <oyydoibh@gmail.com>2018-11-15 23:30:13 +0800
commit9b2ffff62cdbfe6ab538e87aafa5828bfbaaa196 (patch)
tree278f2cbe5e77c6527bea6d3332671704fed933d1 /doc/api/deprecations.md
parentc347e77647ed7c25d2eba4860ce62dbddaa46307 (diff)
downloadandroid-node-v8-9b2ffff62cdbfe6ab538e87aafa5828bfbaaa196.tar.gz
android-node-v8-9b2ffff62cdbfe6ab538e87aafa5828bfbaaa196.tar.bz2
android-node-v8-9b2ffff62cdbfe6ab538e87aafa5828bfbaaa196.zip
tls: emit a warning when servername is an IP address
Setting the TLS ServerName to an IP address is not permitted by RFC6066. This will be ignored in a future version. Refs: https://github.com/nodejs/node/pull/18127 PR-URL: https://github.com/nodejs/node/pull/23329 Fixes: https://github.com/nodejs/node/issues/18071 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'doc/api/deprecations.md')
-rw-r--r--doc/api/deprecations.md15
1 files changed, 15 insertions, 0 deletions
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 681fac92de..a7294145ed 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -2293,6 +2293,20 @@ Type: Runtime
Please use `Server.prototype.setSecureContext()` instead.
+<a id="DEP0123"></a>
+### DEP0123: setting the TLS ServerName to an IP address
+<!-- YAML
+changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/REPLACEME
+ description: Runtime deprecation.
+-->
+
+Type: Runtime
+
+Setting the TLS ServerName to an IP address is not permitted by
+[RFC 6066][]. This will be ignored in a future version.
+
[`--pending-deprecation`]: cli.html#cli_pending_deprecation
[`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size
[`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array
@@ -2393,3 +2407,4 @@ Please use `Server.prototype.setSecureContext()` instead.
[legacy `urlObject`]: url.html#url_legacy_urlobject
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
[WHATWG URL API]: url.html#url_the_whatwg_url_api
+[RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3