diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2017-09-05 23:53:06 +0300 |
|---|---|---|
| committer | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2017-09-10 00:15:49 +0300 |
| commit | 78286984da50ed7f0ed8914b587da62c552277ce (patch) | |
| tree | 8c690095a5c947a2b62796b8ff0828d5a62727d3 /doc/api/addons.md | |
| parent | a2b68723a920b9cc70377727ec0e3bbe11fbe548 (diff) | |
| download | android-node-v8-78286984da50ed7f0ed8914b587da62c552277ce.tar.gz android-node-v8-78286984da50ed7f0ed8914b587da62c552277ce.tar.bz2 android-node-v8-78286984da50ed7f0ed8914b587da62c552277ce.zip | |
test,doc: make module name match gyp target name
Currently the nm_modname does not match the file name of the resulting
module. In fact, the nm_modname is pretty arbitrary. This seeks to
introduce some consistency into the nm_modname property by having the
name of the module appear in exactly one place: the "target_name"
property of the gyp target that builds the module.
PR-URL: https://github.com/nodejs/node/pull/15209
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'doc/api/addons.md')
| -rw-r--r-- | doc/api/addons.md | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/doc/api/addons.md b/doc/api/addons.md index bd17510333..b031c273e7 100644 --- a/doc/api/addons.md +++ b/doc/api/addons.md @@ -74,7 +74,7 @@ void init(Local<Object> exports) { NODE_SET_METHOD(exports, "hello", Method); } -NODE_MODULE(addon, init) +NODE_MODULE(NODE_GYP_MODULE_NAME, init) } // namespace demo ``` @@ -84,7 +84,7 @@ the pattern: ```cpp void Initialize(Local<Object> exports); -NODE_MODULE(module_name, Initialize) +NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) ``` There is no semi-colon after `NODE_MODULE` as it's not a function (see @@ -330,7 +330,7 @@ void Init(Local<Object> exports) { NODE_SET_METHOD(exports, "add", Add); } -NODE_MODULE(addon, Init) +NODE_MODULE(NODE_GYP_MODULE_NAME, Init) } // namespace demo ``` @@ -378,7 +378,7 @@ void Init(Local<Object> exports, Local<Object> module) { NODE_SET_METHOD(module, "exports", RunCallback); } -NODE_MODULE(addon, Init) +NODE_MODULE(NODE_GYP_MODULE_NAME, Init) } // namespace demo ``` @@ -434,7 +434,7 @@ void Init(Local<Object> exports, Local<Object> module) { NODE_SET_METHOD(module, "exports", CreateObject); } -NODE_MODULE(addon, Init) +NODE_MODULE(NODE_GYP_MODULE_NAME, Init) } // namespace demo ``` @@ -493,7 +493,7 @@ void Init(Local<Object> exports, Local<Object> module) { NODE_SET_METHOD(module, "exports", CreateFunction); } -NODE_MODULE(addon, Init) +NODE_MODULE(NODE_GYP_MODULE_NAME, Init) } // namespace demo ``` @@ -529,7 +529,7 @@ void InitAll(Local<Object> exports) { MyObject::Init(exports); } -NODE_MODULE(addon, InitAll) +NODE_MODULE(NODE_GYP_MODULE_NAME, InitAll) } // namespace demo ``` @@ -713,7 +713,7 @@ void InitAll(Local<Object> exports, Local<Object> module) { NODE_SET_METHOD(module, "exports", CreateObject); } -NODE_MODULE(addon, InitAll) +NODE_MODULE(NODE_GYP_MODULE_NAME, InitAll) } // namespace demo ``` @@ -926,7 +926,7 @@ void InitAll(Local<Object> exports) { NODE_SET_METHOD(exports, "add", Add); } -NODE_MODULE(addon, InitAll) +NODE_MODULE(NODE_GYP_MODULE_NAME, InitAll) } // namespace demo ``` @@ -1117,7 +1117,7 @@ void init(Local<Object> exports) { AtExit(sanity_check); } -NODE_MODULE(addon, init) +NODE_MODULE(NODE_GYP_MODULE_NAME, init) } // namespace demo ``` |