summaryrefslogtreecommitdiff
path: root/doc/STYLE_GUIDE.md
diff options
context:
space:
mode:
authorJose M. Palacios Diaz <jmpd1988@gmail.com>2017-11-06 17:22:42 -0500
committerAnna Henningsen <anna@addaleax.net>2017-12-01 21:18:11 +0100
commit845633a7c62ad9ffd33880a43e05a49382bb76bb (patch)
treeaaa2e2e15a13b207e8db74f1011e00870c16cb22 /doc/STYLE_GUIDE.md
parent31e0dbc0c700e7bb8fa453258ba0233975ece575 (diff)
downloadandroid-node-v8-845633a7c62ad9ffd33880a43e05a49382bb76bb.tar.gz
android-node-v8-845633a7c62ad9ffd33880a43e05a49382bb76bb.tar.bz2
android-node-v8-845633a7c62ad9ffd33880a43e05a49382bb76bb.zip
crypto: better docs for cases where peer's public key is invalid
changes in c++ are in the computeSecret function, but the thrown exception that was moved to JS land was in BufferToPoint function, here i let the allocation error be thrown so the only value returned is the nullptr that i use later to catch the error in computeSecret, to then construct the exception in JS land. an ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error was added to errors.js and with that, subsequent changes to docs and tests were made. PR-URL: https://github.com/nodejs/node/pull/16849 Refs: https://www.iacr.org/archive/pkc2003/25670211/25670211.pdf Fixes: https://github.com/nodejs/node/issues/16625 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'doc/STYLE_GUIDE.md')
0 files changed, 0 insertions, 0 deletions