diff options
| author | Refael Ackermann <refack@gmail.com> | 2019-02-04 15:49:47 -0500 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2019-02-14 15:14:46 -0500 |
| commit | ff4adab78c5237a89cb207d9be7e5e81398fe640 (patch) | |
| tree | 45dcd5f4013823df98db154735ee8de490d575f4 /deps | |
| parent | 6ac80f0e2bffcad57b15366f2f833b9bd4a00621 (diff) | |
| download | android-node-v8-ff4adab78c5237a89cb207d9be7e5e81398fe640.tar.gz android-node-v8-ff4adab78c5237a89cb207d9be7e5e81398fe640.tar.bz2 android-node-v8-ff4adab78c5237a89cb207d9be7e5e81398fe640.zip | |
build,win: always build with PCH
PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/gypfiles/v8.gyp | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/deps/v8/gypfiles/v8.gyp b/deps/v8/gypfiles/v8.gyp index de8fd92f7d..857ff0ecec 100644 --- a/deps/v8/gypfiles/v8.gyp +++ b/deps/v8/gypfiles/v8.gyp @@ -365,7 +365,7 @@ }, }, ], - ['OS=="win" and node_use_pch == "true"', { + ['OS=="win"', { 'msvs_precompiled_header': '../../../tools/msvs/pch/v8_pch.h', 'msvs_precompiled_source': '../../../tools/msvs/pch/v8_pch.cc', 'sources': [ @@ -1936,20 +1936,11 @@ }], ['OS=="win"', { 'msvs_disabled_warnings': [4351, 4355, 4800], - 'conditions': [ - ['node_use_pch != "true"', { - # When building Official, the .lib is too large and exceeds the 2G - # limit. This breaks it into multiple pieces to avoid the limit. - # See http://crbug.com/485155. - 'msvs_shard': 4, - }, { 'msvs_precompiled_header': '../../../tools/msvs/pch/v8_pch.h', 'msvs_precompiled_source': '../../../tools/msvs/pch/v8_pch.cc', - 'sources': [ - '<(_msvs_precompiled_header)', - '<(_msvs_precompiled_source)', - ], - }], + 'sources': [ + '<(_msvs_precompiled_header)', + '<(_msvs_precompiled_source)', ], # This will prevent V8's .cc files conflicting with the inspector's # .cpp files in the same shard. |