diff options
| author | Franziska Hinkelmann <franziska.hinkelmann@gmail.com> | 2017-11-08 20:09:54 +0100 |
|---|---|---|
| committer | Franziska Hinkelmann <franziska.hinkelmann@gmail.com> | 2017-11-10 12:35:14 +0100 |
| commit | ccab7d1dac9d625a4d94b0093b212bc7a8c461c6 (patch) | |
| tree | fa38e2d83ebc030f3673c8bd0eeb56bdde598046 /deps | |
| parent | 7af469a605a90260951817bc1e8e370fb28b897e (diff) | |
| download | android-node-v8-ccab7d1dac9d625a4d94b0093b212bc7a8c461c6.tar.gz android-node-v8-ccab7d1dac9d625a4d94b0093b212bc7a8c461c6.tar.bz2 android-node-v8-ccab7d1dac9d625a4d94b0093b212bc7a8c461c6.zip | |
deps: cherry-pick cc55747 from V8 upstream
This fixes the flaky message/console test on our CI.
Original commit message:
[test/message] Allow numbers to have more than one leading digit.
The {NUMBER} regexp only allowed one, leading to occasional test
failures such as:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/17156
Bug:
Change-Id: I25a08b80640d9af19ba70c61c846163685f1cb82
Reviewed-on: https://chromium-review.googlesource.com/753322
Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49109}
PR-URL: https://github.com/nodejs/node/pull/16890
Ref: https://github.com/nodejs/build/issues/936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/test/message/testcfg.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/deps/v8/test/message/testcfg.py b/deps/v8/test/message/testcfg.py index 0576458af2..1bbb2b16d8 100644 --- a/deps/v8/test/message/testcfg.py +++ b/deps/v8/test/message/testcfg.py @@ -107,7 +107,7 @@ class MessageTestSuite(testsuite.TestSuite): expected_lines, actual_lines, fillvalue=''): pattern = re.escape(expected.rstrip() % env) pattern = pattern.replace("\\*", ".*") - pattern = pattern.replace("\\{NUMBER\\}", "\d(?:\.\d*)?") + pattern = pattern.replace("\\{NUMBER\\}", "\d+(?:\.\d*)?") pattern = "^%s$" % pattern if not re.match(pattern, actual): return True |