summaryrefslogtreecommitdiff
path: root/deps
diff options
context:
space:
mode:
authorFedor Indutny <fedor@indutny.com>2015-01-14 04:34:19 +0300
committerFedor Indutny <fedor@indutny.com>2015-01-14 04:34:45 +0300
commitbc8475f2368026369efaa8c85218245047829f3b (patch)
tree1b905f2a3fd3b4c637a9a5df9505275b6e9605c3 /deps
parent95955a1c4d250d509c103a6f9a2708ba4c8cf5b0 (diff)
downloadandroid-node-v8-bc8475f2368026369efaa8c85218245047829f3b.tar.gz
android-node-v8-bc8475f2368026369efaa8c85218245047829f3b.tar.bz2
android-node-v8-bc8475f2368026369efaa8c85218245047829f3b.zip
Revert "deps: update http_parser to 2.4.0"
The commit breaks windows build and brings some test failures that needs to be debugged. This reverts commit d790f612218bb34580bfbc6a11027d69b7c148fe.
Diffstat (limited to 'deps')
-rw-r--r--deps/http_parser/.gitignore1
-rw-r--r--deps/http_parser/.mailmap1
-rw-r--r--deps/http_parser/.travis.yml2
-rw-r--r--deps/http_parser/AUTHORS15
-rw-r--r--deps/http_parser/CONTRIBUTIONS4
-rw-r--r--deps/http_parser/Makefile10
-rw-r--r--deps/http_parser/README.md10
-rw-r--r--deps/http_parser/bench.c111
-rw-r--r--deps/http_parser/contrib/parsertrace.c12
-rw-r--r--deps/http_parser/http_parser.c617
-rw-r--r--deps/http_parser/http_parser.h30
-rw-r--r--deps/http_parser/test.c52
12 files changed, 264 insertions, 601 deletions
diff --git a/deps/http_parser/.gitignore b/deps/http_parser/.gitignore
index 32cb51b2d3..594f3047f4 100644
--- a/deps/http_parser/.gitignore
+++ b/deps/http_parser/.gitignore
@@ -5,7 +5,6 @@ tags
test
test_g
test_fast
-bench
url_parser
parsertrace
parsertrace_g
diff --git a/deps/http_parser/.mailmap b/deps/http_parser/.mailmap
index 278d141263..75a187c568 100644
--- a/deps/http_parser/.mailmap
+++ b/deps/http_parser/.mailmap
@@ -5,4 +5,3 @@ Salman Haq <salman.haq@asti-usa.com>
Simon Zimmermann <simonz05@gmail.com>
Thomas LE ROUX <thomas@november-eleven.fr> LE ROUX Thomas <thomas@procheo.fr>
Thomas LE ROUX <thomas@november-eleven.fr> Thomas LE ROUX <thomas@procheo.fr>
-Fedor Indutny <fedor@indutny.com>
diff --git a/deps/http_parser/.travis.yml b/deps/http_parser/.travis.yml
index 4b038e6e62..ae85af020a 100644
--- a/deps/http_parser/.travis.yml
+++ b/deps/http_parser/.travis.yml
@@ -10,4 +10,4 @@ script:
notifications:
email: false
irc:
- - "irc.freenode.net#node-ci"
+ - "irc.freenode.net#libuv"
diff --git a/deps/http_parser/AUTHORS b/deps/http_parser/AUTHORS
index 29cdbb16d3..51b53b1253 100644
--- a/deps/http_parser/AUTHORS
+++ b/deps/http_parser/AUTHORS
@@ -39,25 +39,12 @@ BogDan Vatra <bogdan@kde.org>
Peter Faiman <peter@thepicard.org>
Corey Richardson <corey@octayn.net>
Tóth Tamás <tomika_nospam@freemail.hu>
+Patrik Stutz <patrik.stutz@gmail.com>
Cam Swords <cam.swords@gmail.com>
Chris Dickinson <christopher.s.dickinson@gmail.com>
Uli Köhler <ukoehler@btronik.de>
Charlie Somerville <charlie@charliesomerville.com>
-Patrik Stutz <patrik.stutz@gmail.com>
Fedor Indutny <fedor.indutny@gmail.com>
runner <runner.mei@gmail.com>
Alexis Campailla <alexis@janeasystems.com>
David Wragg <david@wragg.org>
-Vinnie Falco <vinnie.falco@gmail.com>
-Alex Butum <alexbutum@linux.com>
-Rex Feng <rexfeng@gmail.com>
-Alex Kocharin <alex@kocharin.ru>
-Mark Koopman <markmontymark@yahoo.com>
-Helge Heß <me@helgehess.eu>
-Alexis La Goutte <alexis.lagoutte@gmail.com>
-George Miroshnykov <george.miroshnykov@gmail.com>
-Maciej Małecki <me@mmalecki.com>
-Marc O'Morain <github.com@marcomorain.com>
-Jeff Pinner <jpinner@twitter.com>
-Timothy J Fontaine <tjfontaine@gmail.com>
-Akagi201 <akagi201@gmail.com>
diff --git a/deps/http_parser/CONTRIBUTIONS b/deps/http_parser/CONTRIBUTIONS
new file mode 100644
index 0000000000..11ba31e4b9
--- /dev/null
+++ b/deps/http_parser/CONTRIBUTIONS
@@ -0,0 +1,4 @@
+Contributors must agree to the Contributor License Agreement before patches
+can be accepted.
+
+http://spreadsheets2.google.com/viewform?hl=en&formkey=dDJXOGUwbzlYaWM4cHN1MERwQS1CSnc6MQ
diff --git a/deps/http_parser/Makefile b/deps/http_parser/Makefile
index 2959065a77..3ce463b88b 100644
--- a/deps/http_parser/Makefile
+++ b/deps/http_parser/Makefile
@@ -19,7 +19,7 @@
# IN THE SOFTWARE.
PLATFORM ?= $(shell sh -c 'uname -s | tr "[A-Z]" "[a-z]"')
-SONAME ?= libhttp_parser.so.2.4
+SONAME ?= libhttp_parser.so.2.3
CC?=gcc
AR?=ar
@@ -29,12 +29,10 @@ CPPFLAGS_DEBUG = $(CPPFLAGS) -DHTTP_PARSER_STRICT=1
CPPFLAGS_DEBUG += $(CPPFLAGS_DEBUG_EXTRA)
CPPFLAGS_FAST = $(CPPFLAGS) -DHTTP_PARSER_STRICT=0
CPPFLAGS_FAST += $(CPPFLAGS_FAST_EXTRA)
-CPPFLAGS_BENCH = $(CPPFLAGS_FAST)
CFLAGS += -Wall -Wextra -Werror
CFLAGS_DEBUG = $(CFLAGS) -O0 -g $(CFLAGS_DEBUG_EXTRA)
CFLAGS_FAST = $(CFLAGS) -O3 $(CFLAGS_FAST_EXTRA)
-CFLAGS_BENCH = $(CFLAGS_FAST) -Wno-unused-parameter
CFLAGS_LIB = $(CFLAGS_FAST) -fPIC
LDFLAGS_LIB = $(LDFLAGS) -shared
@@ -63,12 +61,6 @@ test_fast: http_parser.o test.o http_parser.h
test.o: test.c http_parser.h Makefile
$(CC) $(CPPFLAGS_FAST) $(CFLAGS_FAST) -c test.c -o $@
-bench: http_parser.o bench.o
- $(CC) $(CFLAGS_BENCH) $(LDFLAGS) http_parser.o bench.o -o $@
-
-bench.o: bench.c http_parser.h Makefile
- $(CC) $(CPPFLAGS_BENCH) $(CFLAGS_BENCH) -c bench.c -o $@
-
http_parser.o: http_parser.c http_parser.h Makefile
$(CC) $(CPPFLAGS_FAST) $(CFLAGS_FAST) -c http_parser.c
diff --git a/deps/http_parser/README.md b/deps/http_parser/README.md
index 7c54dd42d0..0bf5d359ac 100644
--- a/deps/http_parser/README.md
+++ b/deps/http_parser/README.md
@@ -61,7 +61,7 @@ if (recved < 0) {
}
/* Start up / continue the parser.
- * Note we pass recved==0 to signal that EOF has been received.
+ * Note we pass recved==0 to signal that EOF has been recieved.
*/
nparsed = http_parser_execute(parser, &settings, buf, recved);
@@ -75,7 +75,7 @@ if (parser->upgrade) {
HTTP needs to know where the end of the stream is. For example, sometimes
servers send responses without Content-Length and expect the client to
consume input (for the body) until EOF. To tell http_parser about EOF, give
-`0` as the fourth parameter to `http_parser_execute()`. Callbacks and errors
+`0` as the forth parameter to `http_parser_execute()`. Callbacks and errors
can still be encountered during an EOF, so one must still be prepared
to receive them.
@@ -110,7 +110,7 @@ followed by non-HTTP data.
information the Web Socket protocol.)
To support this, the parser will treat this as a normal HTTP message without a
-body, issuing both on_headers_complete and on_message_complete callbacks. However
+body. Issuing both on_headers_complete and on_message_complete callbacks. However
http_parser_execute() will stop parsing at the end of the headers and return.
The user is expected to check if `parser->upgrade` has been set to 1 after
@@ -131,7 +131,7 @@ There are two types of callbacks:
* notification `typedef int (*http_cb) (http_parser*);`
Callbacks: on_message_begin, on_headers_complete, on_message_complete.
* data `typedef int (*http_data_cb) (http_parser*, const char *at, size_t length);`
- Callbacks: (requests only) on_url,
+ Callbacks: (requests only) on_uri,
(common) on_header_field, on_header_value, on_body;
Callbacks must return 0 on success. Returning a non-zero value indicates
@@ -145,7 +145,7 @@ buffer to avoid copying memory around if this fits your application.
Reading headers may be a tricky task if you read/parse headers partially.
Basically, you need to remember whether last header callback was field or value
-and apply the following logic:
+and apply following logic:
(on_header_field and on_header_value shortened to on_h_*)
------------------------ ------------ --------------------------------------------
diff --git a/deps/http_parser/bench.c b/deps/http_parser/bench.c
deleted file mode 100644
index 5b452fa1cd..0000000000
--- a/deps/http_parser/bench.c
+++ /dev/null
@@ -1,111 +0,0 @@
-/* Copyright Fedor Indutny. All rights reserved.
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
- * deal in the Software without restriction, including without limitation the
- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- */
-#include "http_parser.h"
-#include <assert.h>
-#include <stdio.h>
-#include <string.h>
-#include <sys/time.h>
-
-static const char data[] =
- "POST /joyent/http-parser HTTP/1.1\r\n"
- "Host: github.com\r\n"
- "DNT: 1\r\n"
- "Accept-Encoding: gzip, deflate, sdch\r\n"
- "Accept-Language: ru-RU,ru;q=0.8,en-US;q=0.6,en;q=0.4\r\n"
- "User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) "
- "AppleWebKit/537.36 (KHTML, like Gecko) "
- "Chrome/39.0.2171.65 Safari/537.36\r\n"
- "Accept: text/html,application/xhtml+xml,application/xml;q=0.9,"
- "image/webp,*/*;q=0.8\r\n"
- "Referer: https://github.com/joyent/http-parser\r\n"
- "Connection: keep-alive\r\n"
- "Transfer-Encoding: chunked\r\n"
- "Cache-Control: max-age=0\r\n\r\nb\r\nhello world\r\n0\r\n\r\n";
-static const size_t data_len = sizeof(data) - 1;
-
-static int on_info(http_parser* p) {
- return 0;
-}
-
-
-static int on_data(http_parser* p, const char *at, size_t length) {
- return 0;
-}
-
-static http_parser_settings settings = {
- .on_message_begin = on_info,
- .on_headers_complete = on_info,
- .on_message_complete = on_info,
- .on_header_field = on_data,
- .on_header_value = on_data,
- .on_url = on_data,
- .on_status = on_data,
- .on_body = on_data
-};
-
-int bench(int iter_count, int silent) {
- struct http_parser parser;
- int i;
- int err;
- struct timeval start;
- struct timeval end;
- float rps;
-
- if (!silent) {
- err = gettimeofday(&start, NULL);
- assert(err == 0);
- }
-
- for (i = 0; i < iter_count; i++) {
- size_t parsed;
- http_parser_init(&parser, HTTP_REQUEST);
-
- parsed = http_parser_execute(&parser, &settings, data, data_len);
- assert(parsed == data_len);
- }
-
- if (!silent) {
- err = gettimeofday(&end, NULL);
- assert(err == 0);
-
- fprintf(stdout, "Benchmark result:\n");
-
- rps = (float) (end.tv_sec - start.tv_sec) +
- (end.tv_usec - start.tv_usec) * 1e-6f;
- fprintf(stdout, "Took %f seconds to run\n", rps);
-
- rps = (float) iter_count / rps;
- fprintf(stdout, "%f req/sec\n", rps);
- fflush(stdout);
- }
-
- return 0;
-}
-
-int main(int argc, char** argv) {
- if (argc == 2 && strcmp(argv[1], "infinite") == 0) {
- for (;;)
- bench(5000000, 1);
- return 0;
- } else {
- return bench(5000000, 0);
- }
-}
diff --git a/deps/http_parser/contrib/parsertrace.c b/deps/http_parser/contrib/parsertrace.c
index e7153680f4..c9bc71ec01 100644
--- a/deps/http_parser/contrib/parsertrace.c
+++ b/deps/http_parser/contrib/parsertrace.c
@@ -111,14 +111,14 @@ int main(int argc, char* argv[]) {
FILE* file = fopen(filename, "r");
if (file == NULL) {
perror("fopen");
- goto fail;
+ return EXIT_FAILURE;
}
fseek(file, 0, SEEK_END);
long file_length = ftell(file);
if (file_length == -1) {
perror("ftell");
- goto fail;
+ return EXIT_FAILURE;
}
fseek(file, 0, SEEK_SET);
@@ -126,7 +126,7 @@ int main(int argc, char* argv[]) {
if (fread(data, 1, file_length, file) != (size_t)file_length) {
fprintf(stderr, "couldn't read entire file\n");
free(data);
- goto fail;
+ return EXIT_FAILURE;
}
http_parser_settings settings;
@@ -149,12 +149,8 @@ int main(int argc, char* argv[]) {
"Error: %s (%s)\n",
http_errno_description(HTTP_PARSER_ERRNO(&parser)),
http_errno_name(HTTP_PARSER_ERRNO(&parser)));
- goto fail;
+ return EXIT_FAILURE;
}
return EXIT_SUCCESS;
-
-fail:
- fclose(file);
- return EXIT_FAILURE;
}
diff --git a/deps/http_parser/http_parser.c b/deps/http_parser/http_parser.c
index 23077d1dfe..70cc9bd37b 100644
--- a/deps/http_parser/http_parser.c
+++ b/deps/http_parser/http_parser.c
@@ -56,41 +56,19 @@ do { \
parser->http_errno = (e); \
} while(0)
-#define CURRENT_STATE() p_state
-#define UPDATE_STATE(V) p_state = (V);
-#define RETURN(V) \
-do { \
- parser->state = CURRENT_STATE(); \
- return (V); \
-} while (0);
-#define REEXECUTE() \
- --p; \
- break;
-
-
-#ifdef __GNUC__
-# define LIKELY(X) __builtin_expect(!!(X), 1)
-# define UNLIKELY(X) __builtin_expect(!!(X), 0)
-#else
-# define LIKELY(X) (X)
-# define UNLIKELY(X) (X)
-#endif
-
/* Run the notify callback FOR, returning ER if it fails */
#define CALLBACK_NOTIFY_(FOR, ER) \
do { \
assert(HTTP_PARSER_ERRNO(parser) == HPE_OK); \
\
- if (LIKELY(settings->on_##FOR)) { \
- parser->state = CURRENT_STATE(); \
- if (UNLIKELY(0 != settings->on_##FOR(parser))) { \
+ if (settings->on_##FOR) { \
+ if (0 != settings->on_##FOR(parser)) { \
SET_ERRNO(HPE_CB_##FOR); \
} \
- UPDATE_STATE(parser->state); \
\
/* We either errored above or got paused; get out */ \
- if (UNLIKELY(HTTP_PARSER_ERRNO(parser) != HPE_OK)) { \
+ if (HTTP_PARSER_ERRNO(parser) != HPE_OK) { \
return (ER); \
} \
} \
@@ -108,16 +86,13 @@ do { \
assert(HTTP_PARSER_ERRNO(parser) == HPE_OK); \
\
if (FOR##_mark) { \
- if (LIKELY(settings->on_##FOR)) { \
- parser->state = CURRENT_STATE(); \
- if (UNLIKELY(0 != \
- settings->on_##FOR(parser, FOR##_mark, (LEN)))) { \
+ if (settings->on_##FOR) { \
+ if (0 != settings->on_##FOR(parser, FOR##_mark, (LEN))) { \
SET_ERRNO(HPE_CB_##FOR); \
} \
- UPDATE_STATE(parser->state); \
\
/* We either errored above or got paused; get out */ \
- if (UNLIKELY(HTTP_PARSER_ERRNO(parser) != HPE_OK)) { \
+ if (HTTP_PARSER_ERRNO(parser) != HPE_OK) { \
return (ER); \
} \
} \
@@ -141,26 +116,6 @@ do { \
} \
} while (0)
-/* Don't allow the total size of the HTTP headers (including the status
- * line) to exceed HTTP_MAX_HEADER_SIZE. This check is here to protect
- * embedders against denial-of-service attacks where the attacker feeds
- * us a never-ending header that the embedder keeps buffering.
- *
- * This check is arguably the responsibility of embedders but we're doing
- * it on the embedder's behalf because most won't bother and this way we
- * make the web a little safer. HTTP_MAX_HEADER_SIZE is still far bigger
- * than any reasonable request or response so this should never affect
- * day-to-day operation.
- */
-#define COUNT_HEADER_SIZE(V) \
-do { \
- parser->nread += (V); \
- if (UNLIKELY(parser->nread > (HTTP_MAX_HEADER_SIZE))) { \
- SET_ERRNO(HPE_HEADER_OVERFLOW); \
- goto error; \
- } \
-} while (0)
-
#define PROXY_CONNECTION "proxy-connection"
#define CONNECTION "connection"
@@ -379,16 +334,12 @@ enum header_states
, h_upgrade
, h_matching_transfer_encoding_chunked
- , h_matching_connection_token_start
, h_matching_connection_keep_alive
, h_matching_connection_close
- , h_matching_connection_upgrade
- , h_matching_connection_token
, h_transfer_encoding_chunked
, h_connection_keep_alive
, h_connection_close
- , h_connection_upgrade
};
enum http_host_state
@@ -420,8 +371,6 @@ enum http_host_state
(c) == ';' || (c) == ':' || (c) == '&' || (c) == '=' || (c) == '+' || \
(c) == '$' || (c) == ',')
-#define STRICT_TOKEN(c) (tokens[(unsigned char)c])
-
#if HTTP_PARSER_STRICT
#define TOKEN(c) (tokens[(unsigned char)c])
#define IS_URL_CHAR(c) (BIT_AT(normal_url_char, (unsigned char)c))
@@ -637,7 +586,6 @@ size_t http_parser_execute (http_parser *parser,
const char *url_mark = 0;
const char *body_mark = 0;
const char *status_mark = 0;
- enum state p_state = parser->state;
/* We're in an error state. Don't bother doing anything. */
if (HTTP_PARSER_ERRNO(parser) != HPE_OK) {
@@ -645,7 +593,7 @@ size_t http_parser_execute (http_parser *parser,
}
if (len == 0) {
- switch (CURRENT_STATE()) {
+ switch (parser->state) {
case s_body_identity_eof:
/* Use of CALLBACK_NOTIFY() here would erroneously return 1 byte read if
* we got paused.
@@ -666,11 +614,11 @@ size_t http_parser_execute (http_parser *parser,
}
- if (CURRENT_STATE() == s_header_field)
+ if (parser->state == s_header_field)
header_field_mark = data;
- if (CURRENT_STATE() == s_header_value)
+ if (parser->state == s_header_value)
header_value_mark = data;
- switch (CURRENT_STATE()) {
+ switch (parser->state) {
case s_req_path:
case s_req_schema:
case s_req_schema_slash:
@@ -687,23 +635,38 @@ size_t http_parser_execute (http_parser *parser,
case s_res_status:
status_mark = data;
break;
- default:
- break;
}
for (p=data; p != data + len; p++) {
ch = *p;
- if (PARSING_HEADER(CURRENT_STATE()))
- COUNT_HEADER_SIZE(1);
+ if (PARSING_HEADER(parser->state)) {
+ ++parser->nread;
+ /* Don't allow the total size of the HTTP headers (including the status
+ * line) to exceed HTTP_MAX_HEADER_SIZE. This check is here to protect
+ * embedders against denial-of-service attacks where the attacker feeds
+ * us a never-ending header that the embedder keeps buffering.
+ *
+ * This check is arguably the responsibility of embedders but we're doing
+ * it on the embedder's behalf because most won't bother and this way we
+ * make the web a little safer. HTTP_MAX_HEADER_SIZE is still far bigger
+ * than any reasonable request or response so this should never affect
+ * day-to-day operation.
+ */
+ if (parser->nread > HTTP_MAX_HEADER_SIZE) {
+ SET_ERRNO(HPE_HEADER_OVERFLOW);
+ goto error;
+ }
+ }
- switch (CURRENT_STATE()) {
+ reexecute_byte:
+ switch (parser->state) {
case s_dead:
/* this state is used after a 'Connection: close' message
* the parser will error out if it reads another message
*/
- if (LIKELY(ch == CR || ch == LF))
+ if (ch == CR || ch == LF)
break;
SET_ERRNO(HPE_CLOSED_CONNECTION);
@@ -717,13 +680,13 @@ size_t http_parser_execute (http_parser *parser,
parser->content_length = ULLONG_MAX;
if (ch == 'H') {
- UPDATE_STATE(s_res_or_resp_H);
+ parser->state = s_res_or_resp_H;
CALLBACK_NOTIFY(message_begin);
} else {
parser->type = HTTP_REQUEST;
- UPDATE_STATE(s_start_req);
- REEXECUTE();
+ parser->state = s_start_req;
+ goto reexecute_byte;
}
break;
@@ -732,9 +695,9 @@ size_t http_parser_execute (http_parser *parser,
case s_res_or_resp_H:
if (ch == 'T') {
parser->type = HTTP_RESPONSE;
- UPDATE_STATE(s_res_HT);
+ parser->state = s_res_HT;
} else {
- if (UNLIKELY(ch != 'E')) {
+ if (ch != 'E') {
SET_ERRNO(HPE_INVALID_CONSTANT);
goto error;
}
@@ -742,7 +705,7 @@ size_t http_parser_execute (http_parser *parser,
parser->type = HTTP_REQUEST;
parser->method = HTTP_HEAD;
parser->index = 2;
- UPDATE_STATE(s_req_method);
+ parser->state = s_req_method;
}
break;
@@ -753,7 +716,7 @@ size_t http_parser_execute (http_parser *parser,
switch (ch) {
case 'H':
- UPDATE_STATE(s_res_H);
+ parser->state = s_res_H;
break;
case CR:
@@ -771,39 +734,39 @@ size_t http_parser_execute (http_parser *parser,
case s_res_H:
STRICT_CHECK(ch != 'T');
- UPDATE_STATE(s_res_HT);
+ parser->state = s_res_HT;
break;
case s_res_HT:
STRICT_CHECK(ch != 'T');
- UPDATE_STATE(s_res_HTT);
+ parser->state = s_res_HTT;
break;
case s_res_HTT:
STRICT_CHECK(ch != 'P');
- UPDATE_STATE(s_res_HTTP);
+ parser->state = s_res_HTTP;
break;
case s_res_HTTP:
STRICT_CHECK(ch != '/');
- UPDATE_STATE(s_res_first_http_major);
+ parser->state = s_res_first_http_major;
break;
case s_res_first_http_major:
- if (UNLIKELY(ch < '0' || ch > '9')) {
+ if (ch < '0' || ch > '9') {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
parser->http_major = ch - '0';
- UPDATE_STATE(s_res_http_major);
+ parser->state = s_res_http_major;
break;
/* major HTTP version or dot */
case s_res_http_major:
{
if (ch == '.') {
- UPDATE_STATE(s_res_first_http_minor);
+ parser->state = s_res_first_http_minor;
break;
}
@@ -815,7 +778,7 @@ size_t http_parser_execute (http_parser *parser,
parser->http_major *= 10;
parser->http_major += ch - '0';
- if (UNLIKELY(parser->http_major > 999)) {
+ if (parser->http_major > 999) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -825,24 +788,24 @@ size_t http_parser_execute (http_parser *parser,
/* first digit of minor HTTP version */
case s_res_first_http_minor:
- if (UNLIKELY(!IS_NUM(ch))) {
+ if (!IS_NUM(ch)) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
parser->http_minor = ch - '0';
- UPDATE_STATE(s_res_http_minor);
+ parser->state = s_res_http_minor;
break;
/* minor HTTP version or end of request line */
case s_res_http_minor:
{
if (ch == ' ') {
- UPDATE_STATE(s_res_first_status_code);
+ parser->state = s_res_first_status_code;
break;
}
- if (UNLIKELY(!IS_NUM(ch))) {
+ if (!IS_NUM(ch)) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -850,7 +813,7 @@ size_t http_parser_execute (http_parser *parser,
parser->http_minor *= 10;
parser->http_minor += ch - '0';
- if (UNLIKELY(parser->http_minor > 999)) {
+ if (parser->http_minor > 999) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -869,7 +832,7 @@ size_t http_parser_execute (http_parser *parser,
goto error;
}
parser->status_code = ch - '0';
- UPDATE_STATE(s_res_status_code);
+ parser->state = s_res_status_code;
break;
}
@@ -878,13 +841,13 @@ size_t http_parser_execute (http_parser *parser,
if (!IS_NUM(ch)) {
switch (ch) {
case ' ':
- UPDATE_STATE(s_res_status_start);
+ parser->state = s_res_status_start;
break;
case CR:
- UPDATE_STATE(s_res_line_almost_done);
+ parser->state = s_res_line_almost_done;
break;
case LF:
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
break;
default:
SET_ERRNO(HPE_INVALID_STATUS);
@@ -896,7 +859,7 @@ size_t http_parser_execute (http_parser *parser,
parser->status_code *= 10;
parser->status_code += ch - '0';
- if (UNLIKELY(parser->status_code > 999)) {
+ if (parser->status_code > 999) {
SET_ERRNO(HPE_INVALID_STATUS);
goto error;
}
@@ -907,30 +870,30 @@ size_t http_parser_execute (http_parser *parser,
case s_res_status_start:
{
if (ch == CR) {
- UPDATE_STATE(s_res_line_almost_done);
+ parser->state = s_res_line_almost_done;
break;
}
if (ch == LF) {
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
break;
}
MARK(status);
- UPDATE_STATE(s_res_status);
+ parser->state = s_res_status;
parser->index = 0;
break;
}
case s_res_status:
if (ch == CR) {
- UPDATE_STATE(s_res_line_almost_done);
+ parser->state = s_res_line_almost_done;
CALLBACK_DATA(status);
break;
}
if (ch == LF) {
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
CALLBACK_DATA(status);
break;
}
@@ -939,7 +902,7 @@ size_t http_parser_execute (http_parser *parser,
case s_res_line_almost_done:
STRICT_CHECK(ch != LF);
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
break;
case s_start_req:
@@ -949,7 +912,7 @@ size_t http_parser_execute (http_parser *parser,
parser->flags = 0;
parser->content_length = ULLONG_MAX;
- if (UNLIKELY(!IS_ALPHA(ch))) {
+ if (!IS_ALPHA(ch)) {
SET_ERRNO(HPE_INVALID_METHOD);
goto error;
}
@@ -962,7 +925,7 @@ size_t http_parser_execute (http_parser *parser,
case 'G': parser->method = HTTP_GET; break;
case 'H': parser->method = HTTP_HEAD; break;
case 'L': parser->method = HTTP_LOCK; break;
- case 'M': parser->method = HTTP_MKCOL; /* or MOVE, MKACTIVITY, MERGE, M-SEARCH, MKCALENDAR */ break;
+ case 'M': parser->method = HTTP_MKCOL; /* or MOVE, MKACTIVITY, MERGE, M-SEARCH */ break;
case 'N': parser->method = HTTP_NOTIFY; break;
case 'O': parser->method = HTTP_OPTIONS; break;
case 'P': parser->method = HTTP_POST;
@@ -976,7 +939,7 @@ size_t http_parser_execute (http_parser *parser,
SET_ERRNO(HPE_INVALID_METHOD);
goto error;
}
- UPDATE_STATE(s_req_method);
+ parser->state = s_req_method;
CALLBACK_NOTIFY(message_begin);
@@ -986,14 +949,14 @@ size_t http_parser_execute (http_parser *parser,
case s_req_method:
{
const char *matcher;
- if (UNLIKELY(ch == '\0')) {
+ if (ch == '\0') {
SET_ERRNO(HPE_INVALID_METHOD);
goto error;
}
matcher = method_strings[parser->method];
if (ch == ' ' && matcher[parser->index] == '\0') {
- UPDATE_STATE(s_req_spaces_before_url);
+ parser->state = s_req_spaces_before_url;
} else if (ch == matcher[parser->index]) {
; /* nada */
} else if (parser->method == HTTP_CONNECT) {
@@ -1014,8 +977,6 @@ size_t http_parser_execute (http_parser *parser,
parser->method = HTTP_MSEARCH;
} else if (parser->index == 2 && ch == 'A') {
parser->method = HTTP_MKACTIVITY;
- } else if (parser->index == 3 && ch == 'A') {
- parser->method = HTTP_MKCALENDAR;
} else {
SET_ERRNO(HPE_INVALID_METHOD);
goto error;
@@ -1074,11 +1035,11 @@ size_t http_parser_execute (http_parser *parser,
MARK(url);
if (parser->method == HTTP_CONNECT) {
- UPDATE_STATE(s_req_server_start);
+ parser->state = s_req_server_start;
}
- UPDATE_STATE(parse_url_char(CURRENT_STATE(), ch));
- if (UNLIKELY(CURRENT_STATE() == s_dead)) {
+ parser->state = parse_url_char((enum state)parser->state, ch);
+ if (parser->state == s_dead) {
SET_ERRNO(HPE_INVALID_URL);
goto error;
}
@@ -1099,8 +1060,8 @@ size_t http_parser_execute (http_parser *parser,
SET_ERRNO(HPE_INVALID_URL);
goto error;
default:
- UPDATE_STATE(parse_url_char(CURRENT_STATE(), ch));
- if (UNLIKELY(CURRENT_STATE() == s_dead)) {
+ parser->state = parse_url_char((enum state)parser->state, ch);
+ if (parser->state == s_dead) {
SET_ERRNO(HPE_INVALID_URL);
goto error;
}
@@ -1119,21 +1080,21 @@ size_t http_parser_execute (http_parser *parser,
{
switch (ch) {
case ' ':
- UPDATE_STATE(s_req_http_start);
+ parser->state = s_req_http_start;
CALLBACK_DATA(url);
break;
case CR:
case LF:
parser->http_major = 0;
parser->http_minor = 9;
- UPDATE_STATE((ch == CR) ?
+ parser->state = (ch == CR) ?
s_req_line_almost_done :
- s_header_field_start);
+ s_header_field_start;
CALLBACK_DATA(url);
break;
default:
- UPDATE_STATE(parse_url_char(CURRENT_STATE(), ch));
- if (UNLIKELY(CURRENT_STATE() == s_dead)) {
+ parser->state = parse_url_char((enum state)parser->state, ch);
+ if (parser->state == s_dead) {
SET_ERRNO(HPE_INVALID_URL);
goto error;
}
@@ -1144,7 +1105,7 @@ size_t http_parser_execute (http_parser *parser,
case s_req_http_start:
switch (ch) {
case 'H':
- UPDATE_STATE(s_req_http_H);
+ parser->state = s_req_http_H;
break;
case ' ':
break;
@@ -1156,44 +1117,44 @@ size_t http_parser_execute (http_parser *parser,
case s_req_http_H:
STRICT_CHECK(ch != 'T');
- UPDATE_STATE(s_req_http_HT);
+ parser->state = s_req_http_HT;
break;
case s_req_http_HT:
STRICT_CHECK(ch != 'T');
- UPDATE_STATE(s_req_http_HTT);
+ parser->state = s_req_http_HTT;
break;
case s_req_http_HTT:
STRICT_CHECK(ch != 'P');
- UPDATE_STATE(s_req_http_HTTP);
+ parser->state = s_req_http_HTTP;
break;
case s_req_http_HTTP:
STRICT_CHECK(ch != '/');
- UPDATE_STATE(s_req_first_http_major);
+ parser->state = s_req_first_http_major;
break;
/* first digit of major HTTP version */
case s_req_first_http_major:
- if (UNLIKELY(ch < '1' || ch > '9')) {
+ if (ch < '1' || ch > '9') {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
parser->http_major = ch - '0';
- UPDATE_STATE(s_req_http_major);
+ parser->state = s_req_http_major;
break;
/* major HTTP version or dot */
case s_req_http_major:
{
if (ch == '.') {
- UPDATE_STATE(s_req_first_http_minor);
+ parser->state = s_req_first_http_minor;
break;
}
- if (UNLIKELY(!IS_NUM(ch))) {
+ if (!IS_NUM(ch)) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -1201,7 +1162,7 @@ size_t http_parser_execute (http_parser *parser,
parser->http_major *= 10;
parser->http_major += ch - '0';
- if (UNLIKELY(parser->http_major > 999)) {
+ if (parser->http_major > 999) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -1211,31 +1172,31 @@ size_t http_parser_execute (http_parser *parser,
/* first digit of minor HTTP version */
case s_req_first_http_minor:
- if (UNLIKELY(!IS_NUM(ch))) {
+ if (!IS_NUM(ch)) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
parser->http_minor = ch - '0';
- UPDATE_STATE(s_req_http_minor);
+ parser->state = s_req_http_minor;
break;
/* minor HTTP version or end of request line */
case s_req_http_minor:
{
if (ch == CR) {
- UPDATE_STATE(s_req_line_almost_done);
+ parser->state = s_req_line_almost_done;
break;
}
if (ch == LF) {
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
break;
}
/* XXX allow spaces after digit? */
- if (UNLIKELY(!IS_NUM(ch))) {
+ if (!IS_NUM(ch)) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -1243,7 +1204,7 @@ size_t http_parser_execute (http_parser *parser,
parser->http_minor *= 10;
parser->http_minor += ch - '0';
- if (UNLIKELY(parser->http_minor > 999)) {
+ if (parser->http_minor > 999) {
SET_ERRNO(HPE_INVALID_VERSION);
goto error;
}
@@ -1254,32 +1215,32 @@ size_t http_parser_execute (http_parser *parser,
/* end of request line */
case s_req_line_almost_done:
{
- if (UNLIKELY(ch != LF)) {
+ if (ch != LF) {
SET_ERRNO(HPE_LF_EXPECTED);
goto error;
}
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
break;
}
case s_header_field_start:
{
if (ch == CR) {
- UPDATE_STATE(s_headers_almost_done);
+ parser->state = s_headers_almost_done;
break;
}
if (ch == LF) {
/* they might be just sending \n instead of \r\n so this would be
* the second \n to denote the end of headers*/
- UPDATE_STATE(s_headers_almost_done);
- REEXECUTE();
+ parser->state = s_headers_almost_done;
+ goto reexecute_byte;
}
c = TOKEN(ch);
- if (UNLIKELY(!c)) {
+ if (!c) {
SET_ERRNO(HPE_INVALID_HEADER_TOKEN);
goto error;
}
@@ -1287,7 +1248,7 @@ size_t http_parser_execute (http_parser *parser,
MARK(header_field);
parser->index = 0;
- UPDATE_STATE(s_header_field);
+ parser->state = s_header_field;
switch (c) {
case 'c':
@@ -1315,14 +1276,9 @@ size_t http_parser_execute (http_parser *parser,
case s_header_field:
{
- const char* start = p;
- for (; p != data + len; p++) {
- ch = *p;
- c = TOKEN(ch);
-
- if (!c)
- break;
+ c = TOKEN(ch);
+ if (c) {
switch (parser->header_state) {
case h_general:
break;
@@ -1423,17 +1379,23 @@ size_t http_parser_execute (http_parser *parser,
assert(0 && "Unknown header_state");
break;
}
+ break;
}
- COUNT_HEADER_SIZE(p - start);
+ if (ch == ':') {
+ parser->state = s_header_value_discard_ws;
+ CALLBACK_DATA(header_field);
+ break;
+ }
- if (p == data + len) {
- --p;
+ if (ch == CR) {
+ parser->state = s_header_almost_done;
+ CALLBACK_DATA(header_field);
break;
}
- if (ch == ':') {
- UPDATE_STATE(s_header_value_discard_ws);
+ if (ch == LF) {
+ parser->state = s_header_field_start;
CALLBACK_DATA(header_field);
break;
}
@@ -1446,12 +1408,12 @@ size_t http_parser_execute (http_parser *parser,
if (ch == ' ' || ch == '\t') break;
if (ch == CR) {
- UPDATE_STATE(s_header_value_discard_ws_almost_done);
+ parser->state = s_header_value_discard_ws_almost_done;
break;
}
if (ch == LF) {
- UPDATE_STATE(s_header_value_discard_lws);
+ parser->state = s_header_value_discard_lws;
break;
}
@@ -1461,7 +1423,7 @@ size_t http_parser_execute (http_parser *parser,
{
MARK(header_value);
- UPDATE_STATE(s_header_value);
+ parser->state = s_header_value;
parser->index = 0;
c = LOWER(ch);
@@ -1482,7 +1444,7 @@ size_t http_parser_execute (http_parser *parser,
break;
case h_content_length:
- if (UNLIKELY(!IS_NUM(ch))) {
+ if (!IS_NUM(ch)) {
SET_ERRNO(HPE_INVALID_CONTENT_LENGTH);
goto error;
}
@@ -1497,17 +1459,11 @@ size_t http_parser_execute (http_parser *parser,
/* looking for 'Connection: close' */
} else if (c == 'c') {
parser->header_state = h_matching_connection_close;
- } else if (c == 'u') {
- parser->header_state = h_matching_connection_upgrade;
} else {
- parser->header_state = h_matching_connection_token;
+ parser->header_state = h_general;
}
break;
- /* Multi-value `Connection` header */
- case h_matching_connection_token_start:
- break;
-
default:
parser->header_state = h_general;
break;
@@ -1517,185 +1473,98 @@ size_t http_parser_execute (http_parser *parser,
case s_header_value:
{
- const char* start = p;
- enum header_states h_state = parser->header_state;
- for (; p != data + len; p++) {
- ch = *p;
- if (ch == CR) {
- UPDATE_STATE(s_header_almost_done);
- parser->header_state = h_state;
- CALLBACK_DATA(header_value);
- break;
- }
- if (ch == LF) {
- UPDATE_STATE(s_header_almost_done);
- COUNT_HEADER_SIZE(p - start);
- parser->header_state = h_state;
- CALLBACK_DATA_NOADVANCE(header_value);
- REEXECUTE();
- }
-
- c = LOWER(ch);
-
- switch (h_state) {
- case h_general:
- {
- const char* p_cr;
- const char* p_lf;
- size_t limit = data + len - p;
-
- limit = MIN(limit, HTTP_MAX_HEADER_SIZE);
-
- p_cr = memchr(p, CR, limit);
- p_lf = memchr(p, LF, limit);
- if (p_cr != NULL) {
- if (p_lf != NULL && p_cr >= p_lf)
- p = p_lf;
- else
- p = p_cr;
- } else if (UNLIKELY(p_lf != NULL)) {
- p = p_lf;
- } else {
- p = data + len;
- }
- --p;
-
- break;
- }
+ if (ch == CR) {
+ parser->state = s_header_almost_done;
+ CALLBACK_DATA(header_value);
+ break;
+ }
- case h_connection:
- case h_transfer_encoding:
- assert(0 && "Shouldn't get here.");
- break;
+ if (ch == LF) {
+ parser->state = s_header_almost_done;
+ CALLBACK_DATA_NOADVANCE(header_value);
+ goto reexecute_byte;
+ }
- case h_content_length:
- {
- uint64_t t;
+ c = LOWER(ch);
- if (ch == ' ') break;
+ switch (parser->header_state) {
+ case h_general:
+ break;
- if (UNLIKELY(!IS_NUM(ch))) {
- SET_ERRNO(HPE_INVALID_CONTENT_LENGTH);
- parser->header_state = h_state;
- goto error;
- }
+ case h_connection:
+ case h_transfer_encoding:
+ assert(0 && "Shouldn't get here.");
+ break;
- t = parser->content_length;
- t *= 10;
- t += ch - '0';
+ case h_content_length:
+ {
+ uint64_t t;
- /* Overflow? Test against a conservative limit for simplicity. */
- if (UNLIKELY((ULLONG_MAX - 10) / 10 < parser->content_length)) {
- SET_ERRNO(HPE_INVALID_CONTENT_LENGTH);
- parser->header_state = h_state;
- goto error;
- }
+ if (ch == ' ') break;
- parser->content_length = t;
- break;
+ if (!IS_NUM(ch)) {
+ SET_ERRNO(HPE_INVALID_CONTENT_LENGTH);
+ goto error;
}
- /* Transfer-Encoding: chunked */
- case h_matching_transfer_encoding_chunked:
- parser->index++;
- if (parser->index > sizeof(CHUNKED)-1
- || c != CHUNKED[parser->index]) {
- h_state = h_general;
- } else if (parser->index == sizeof(CHUNKED)-2) {
- h_state = h_transfer_encoding_chunked;
- }
- break;
+ t = parser->content_length;
+ t *= 10;
+ t += ch - '0';
- case h_matching_connection_token_start:
- /* looking for 'Connection: keep-alive' */
- if (c == 'k') {
- h_state = h_matching_connection_keep_alive;
- /* looking for 'Connection: close' */
- } else if (c == 'c') {
- h_state = h_matching_connection_close;
- } else if (c == 'u') {
- h_state = h_matching_connection_upgrade;
- } else if (STRICT_TOKEN(c)) {
- h_state = h_matching_connection_token;
- } else {
- h_state = h_general;
- }
- break;
-
- /* looking for 'Connection: keep-alive' */
- case h_matching_connection_keep_alive:
- parser->index++;
- if (parser->index > sizeof(KEEP_ALIVE)-1
- || c != KEEP_ALIVE[parser->index]) {
- h_state = h_matching_connection_token;
- } else if (parser->index == sizeof(KEEP_ALIVE)-2) {
- h_state = h_connection_keep_alive;
- }
- break;
+ /* Overflow? Test against a conservative limit for simplicity. */
+ if ((ULLONG_MAX - 10) / 10 < parser->content_length) {
+ SET_ERRNO(HPE_INVALID_CONTENT_LENGTH);
+ goto error;
+ }
- /* looking for 'Connection: close' */
- case h_matching_connection_close:
- parser->index++;
- if (parser->index > sizeof(CLOSE)-1 || c != CLOSE[parser->index]) {
- h_state = h_matching_connection_token;
- } else if (parser->index == sizeof(CLOSE)-2) {
- h_state = h_connection_close;
- }
- break;
+ parser->content_length = t;
+ break;
+ }
- /* looking for 'Connection: upgrade' */
- case h_matching_connection_upgrade:
- parser->index++;
- if (parser->index > sizeof(UPGRADE) - 1 ||
- c != UPGRADE[parser->index]) {
- h_state = h_matching_connection_token;
- } else if (parser->index == sizeof(UPGRADE)-2) {
- h_state = h_connection_upgrade;
- }
- break;
+ /* Transfer-Encoding: chunked */
+ case h_matching_transfer_encoding_chunked:
+ parser->index++;
+ if (parser->index > sizeof(CHUNKED)-1
+ || c != CHUNKED[parser->index]) {
+ parser->header_state = h_general;
+ } else if (parser->index == sizeof(CHUNKED)-2) {
+ parser->header_state = h_transfer_encoding_chunked;
+ }
+ break;
- case h_matching_connection_token:
- if (ch == ',') {
- h_state = h_matching_connection_token_start;
- parser->index = 0;
- }
- break;
+ /* looking for 'Connection: keep-alive' */
+ case h_matching_connection_keep_alive:
+ parser->index++;
+ if (parser->index > sizeof(KEEP_ALIVE)-1
+ || c != KEEP_ALIVE[parser->index]) {
+ parser->header_state = h_general;
+ } else if (parser->index == sizeof(KEEP_ALIVE)-2) {
+ parser->header_state = h_connection_keep_alive;
+ }
+ break;
- case h_transfer_encoding_chunked:
- if (ch != ' ') h_state = h_general;
- break;
+ /* looking for 'Connection: close' */
+ case h_matching_connection_close:
+ parser->index++;
+ if (parser->index > sizeof(CLOSE)-1 || c != CLOSE[parser->index]) {
+ parser->header_state = h_general;
+ } else if (parser->index == sizeof(CLOSE)-2) {
+ parser->header_state = h_connection_close;
+ }
+ break;
- case h_connection_keep_alive:
- case h_connection_close:
- case h_connection_upgrade:
- if (ch == ',') {
- if (h_state == h_connection_keep_alive) {
- parser->flags |= F_CONNECTION_KEEP_ALIVE;
- } else if (h_state == h_connection_close) {
- parser->flags |= F_CONNECTION_CLOSE;
- } else if (h_state == h_connection_upgrade) {
- parser->flags |= F_CONNECTION_UPGRADE;
- }
- h_state = h_matching_connection_token_start;
- parser->index = 0;
- } else if (ch != ' ') {
- h_state = h_matching_connection_token;
- }
- break;
+ case h_transfer_encoding_chunked:
+ case h_connection_keep_alive:
+ case h_connection_close:
+ if (ch != ' ') parser->header_state = h_general;
+ break;
- default:
- UPDATE_STATE(s_header_value);
- h_state = h_general;
- break;
- }
+ default:
+ parser->state = s_header_value;
+ parser->header_state = h_general;
+ break;
}
- parser->header_state = h_state;
-
- COUNT_HEADER_SIZE(p - start);
-
- if (p == data + len)
- --p;
break;
}
@@ -1703,15 +1572,15 @@ size_t http_parser_execute (http_parser *parser,
{
STRICT_CHECK(ch != LF);
- UPDATE_STATE(s_header_value_lws);
+ parser->state = s_header_value_lws;
break;
}
case s_header_value_lws:
{
if (ch == ' ' || ch == '\t') {
- UPDATE_STATE(s_header_value_start);
- REEXECUTE();
+ parser->state = s_header_value_start;
+ goto reexecute_byte;
}
/* finished the header */
@@ -1725,52 +1594,32 @@ size_t http_parser_execute (http_parser *parser,
case h_transfer_encoding_chunked:
parser->flags |= F_CHUNKED;
break;
- case h_connection_upgrade:
- parser->flags |= F_CONNECTION_UPGRADE;
- break;
default:
break;
}
- UPDATE_STATE(s_header_field_start);
- REEXECUTE();
+ parser->state = s_header_field_start;
+ goto reexecute_byte;
}
case s_header_value_discard_ws_almost_done:
{
STRICT_CHECK(ch != LF);
- UPDATE_STATE(s_header_value_discard_lws);
+ parser->state = s_header_value_discard_lws;
break;
}
case s_header_value_discard_lws:
{
if (ch == ' ' || ch == '\t') {
- UPDATE_STATE(s_header_value_discard_ws);
+ parser->state = s_header_value_discard_ws;
break;
} else {
- switch (parser->header_state) {
- case h_connection_keep_alive:
- parser->flags |= F_CONNECTION_KEEP_ALIVE;
- break;
- case h_connection_close:
- parser->flags |= F_CONNECTION_CLOSE;
- break;
- case h_connection_upgrade:
- parser->flags |= F_CONNECTION_UPGRADE;
- break;
- case h_transfer_encoding_chunked:
- parser->flags |= F_CHUNKED;
- break;
- default:
- break;
- }
-
/* header value was empty */
MARK(header_value);
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
CALLBACK_DATA_NOADVANCE(header_value);
- REEXECUTE();
+ goto reexecute_byte;
}
}
@@ -1780,18 +1629,16 @@ size_t http_parser_execute (http_parser *parser,
if (parser->flags & F_TRAILING) {
/* End of a chunked request */
- UPDATE_STATE(NEW_MESSAGE());
+ parser->state = NEW_MESSAGE();
CALLBACK_NOTIFY(message_complete);
break;
}
- UPDATE_STATE(s_headers_done);
+ parser->state = s_headers_done;
/* Set this here so that on_headers_complete() callbacks can see it */
parser->upgrade =
- ((parser->flags & (F_UPGRADE | F_CONNECTION_UPGRADE)) ==
- (F_UPGRADE | F_CONNECTION_UPGRADE) ||
- parser->method == HTTP_CONNECT);
+ (parser->flags & F_UPGRADE || parser->method == HTTP_CONNECT);
/* Here we call the headers_complete callback. This is somewhat
* different than other callbacks because if the user returns 1, we
@@ -1813,15 +1660,15 @@ size_t http_parser_execute (http_parser *parser,
default:
SET_ERRNO(HPE_CB_headers_complete);
- RETURN(p - data); /* Error */
+ return p - data; /* Error */
}
}
if (HTTP_PARSER_ERRNO(parser) != HPE_OK) {
- RETURN(p - data);
+ return p - data;
}
- REEXECUTE();
+ goto reexecute_byte;
}
case s_headers_done:
@@ -1832,34 +1679,34 @@ size_t http_parser_execute (http_parser *parser,
/* Exit, the rest of the connect is in a different protocol. */
if (parser->upgrade) {
- UPDATE_STATE(NEW_MESSAGE());
+ parser->state = NEW_MESSAGE();
CALLBACK_NOTIFY(message_complete);
- RETURN((p - data) + 1);
+ return (p - data) + 1;
}
if (parser->flags & F_SKIPBODY) {
- UPDATE_STATE(NEW_MESSAGE());
+ parser->state = NEW_MESSAGE();
CALLBACK_NOTIFY(message_complete);
} else if (parser->flags & F_CHUNKED) {
/* chunked encoding - ignore Content-Length header */
- UPDATE_STATE(s_chunk_size_start);
+ parser->state = s_chunk_size_start;
} else {
if (parser->content_length == 0) {
/* Content-Length header given but zero: Content-Length: 0\r\n */
- UPDATE_STATE(NEW_MESSAGE());
+ parser->state = NEW_MESSAGE();
CALLBACK_NOTIFY(message_complete);
} else if (parser->content_length != ULLONG_MAX) {
/* Content-Length header given and non-zero */
- UPDATE_STATE(s_body_identity);
+ parser->state = s_body_identity;
} else {
if (parser->type == HTTP_REQUEST ||
!http_message_needs_eof(parser)) {
/* Assume content-length 0 - read the next */
- UPDATE_STATE(NEW_MESSAGE());
+ parser->state = NEW_MESSAGE();
CALLBACK_NOTIFY(message_complete);
} else {
/* Read body until EOF */
- UPDATE_STATE(s_body_identity_eof);
+ parser->state = s_body_identity_eof;
}
}
}
@@ -1885,7 +1732,7 @@ size_t http_parser_execute (http_parser *parser,
p += to_read - 1;
if (parser->content_length == 0) {
- UPDATE_STATE(s_message_done);
+ parser->state = s_message_done;
/* Mimic CALLBACK_DATA_NOADVANCE() but with one extra byte.
*
@@ -1897,7 +1744,7 @@ size_t http_parser_execute (http_parser *parser,
* important for applications, but let's keep it for now.
*/
CALLBACK_DATA_(body, p - body_mark + 1, p - data);
- REEXECUTE();
+ goto reexecute_byte;
}
break;
@@ -1911,7 +1758,7 @@ size_t http_parser_execute (http_parser *parser,
break;
case s_message_done:
- UPDATE_STATE(NEW_MESSAGE());
+ parser->state = NEW_MESSAGE();
CALLBACK_NOTIFY(message_complete);
break;
@@ -1921,13 +1768,13 @@ size_t http_parser_execute (http_parser *parser,
assert(parser->flags & F_CHUNKED);
unhex_val = unhex[(unsigned char)ch];
- if (UNLIKELY(unhex_val == -1)) {
+ if (unhex_val == -1) {
SET_ERRNO(HPE_INVALID_CHUNK_SIZE);
goto error;
}
parser->content_length = unhex_val;
- UPDATE_STATE(s_chunk_size);
+ parser->state = s_chunk_size;
break;
}
@@ -1938,7 +1785,7 @@ size_t http_parser_execute (http_parser *parser,
assert(parser->flags & F_CHUNKED);
if (ch == CR) {
- UPDATE_STATE(s_chunk_size_almost_done);
+ parser->state = s_chunk_size_almost_done;
break;
}
@@ -1946,7 +1793,7 @@ size_t http_parser_execute (http_parser *parser,
if (unhex_val == -1) {
if (ch == ';' || ch == ' ') {
- UPDATE_STATE(s_chunk_parameters);
+ parser->state = s_chunk_parameters;
break;
}
@@ -1959,7 +1806,7 @@ size_t http_parser_execute (http_parser *parser,
t += unhex_val;
/* Overflow? Test against a conservative limit for simplicity. */
- if (UNLIKELY((ULLONG_MAX - 16) / 16 < parser->content_length)) {
+ if ((ULLONG_MAX - 16) / 16 < parser->content_length) {
SET_ERRNO(HPE_INVALID_CONTENT_LENGTH);
goto error;
}
@@ -1973,7 +1820,7 @@ size_t http_parser_execute (http_parser *parser,
assert(parser->flags & F_CHUNKED);
/* just ignore this shit. TODO check for overflow */
if (ch == CR) {
- UPDATE_STATE(s_chunk_size_almost_done);
+ parser->state = s_chunk_size_almost_done;
break;
}
break;
@@ -1988,9 +1835,9 @@ size_t http_parser_execute (http_parser *parser,
if (parser->content_length == 0) {
parser->flags |= F_TRAILING;
- UPDATE_STATE(s_header_field_start);
+ parser->state = s_header_field_start;
} else {
- UPDATE_STATE(s_chunk_data);
+ parser->state = s_chunk_data;
}
break;
}
@@ -2012,7 +1859,7 @@ size_t http_parser_execute (http_parser *parser,
p += to_read - 1;
if (parser->content_length == 0) {
- UPDATE_STATE(s_chunk_data_almost_done);
+ parser->state = s_chunk_data_almost_done;
}
break;
@@ -2022,7 +1869,7 @@ size_t http_parser_execute (http_parser *parser,
assert(parser->flags & F_CHUNKED);
assert(parser->content_length == 0);
STRICT_CHECK(ch != CR);
- UPDATE_STATE(s_chunk_data_done);
+ parser->state = s_chunk_data_done;
CALLBACK_DATA(body);
break;
@@ -2030,7 +1877,7 @@ size_t http_parser_execute (http_parser *parser,
assert(parser->flags & F_CHUNKED);
STRICT_CHECK(ch != LF);
parser->nread = 0;
- UPDATE_STATE(s_chunk_size_start);
+ parser->state = s_chunk_size_start;
break;
default:
@@ -2062,14 +1909,14 @@ size_t http_parser_execute (http_parser *parser,
CALLBACK_DATA_NOADVANCE(body);
CALLBACK_DATA_NOADVANCE(status);
- RETURN(len);
+ return len;
error:
if (HTTP_PARSER_ERRNO(parser) == HPE_OK) {
SET_ERRNO(HPE_UNKNOWN);
}
- RETURN(p - data);
+ return (p - data);
}
@@ -2295,7 +2142,7 @@ http_parser_parse_url(const char *buf, size_t buflen, int is_connect,
u->port = u->field_set = 0;
s = is_connect ? s_req_server_start : s_req_spaces_before_url;
- old_uf = UF_MAX;
+ uf = old_uf = UF_MAX;
for (p = buf; p < buf + buflen; p++) {
s = parse_url_char(s, *p);
diff --git a/deps/http_parser/http_parser.h b/deps/http_parser/http_parser.h
index e06f10fe73..ec61a1287f 100644
--- a/deps/http_parser/http_parser.h
+++ b/deps/http_parser/http_parser.h
@@ -26,7 +26,7 @@ extern "C" {
/* Also update SONAME in the Makefile whenever you change these. */
#define HTTP_PARSER_VERSION_MAJOR 2
-#define HTTP_PARSER_VERSION_MINOR 4
+#define HTTP_PARSER_VERSION_MINOR 3
#define HTTP_PARSER_VERSION_PATCH 0
#include <sys/types.h>
@@ -52,16 +52,9 @@ typedef unsigned __int64 uint64_t;
# define HTTP_PARSER_STRICT 1
#endif
-/* Maximium header size allowed. If the macro is not defined
- * before including this header then the default is used. To
- * change the maximum header size, define the macro in the build
- * environment (e.g. -DHTTP_MAX_HEADER_SIZE=<value>). To remove
- * the effective limit on the size of the header, define the macro
- * to a very large number (e.g. -DHTTP_MAX_HEADER_SIZE=0x7fffffff)
- */
-#ifndef HTTP_MAX_HEADER_SIZE
-# define HTTP_MAX_HEADER_SIZE (80*1024)
-#endif
+/* Maximium header size allowed */
+#define HTTP_MAX_HEADER_SIZE (80*1024)
+
typedef struct http_parser http_parser;
typedef struct http_parser_settings http_parser_settings;
@@ -76,7 +69,7 @@ typedef struct http_parser_settings http_parser_settings;
* HEAD request which may contain 'Content-Length' or 'Transfer-Encoding:
* chunked' headers that indicate the presence of a body.
*
- * http_data_cb does not return data chunks. It will be called arbitrarily
+ * http_data_cb does not return data chunks. It will be call arbitrarally
* many times for each string. E.G. you might get 10 callbacks for "on_url"
* each providing just a few characters more data.
*/
@@ -117,8 +110,6 @@ typedef int (*http_cb) (http_parser*);
/* RFC-5789 */ \
XX(24, PATCH, PATCH) \
XX(25, PURGE, PURGE) \
- /* CalDAV */ \
- XX(26, MKCALENDAR, MKCALENDAR) \
enum http_method
{
@@ -136,10 +127,9 @@ enum flags
{ F_CHUNKED = 1 << 0
, F_CONNECTION_KEEP_ALIVE = 1 << 1
, F_CONNECTION_CLOSE = 1 << 2
- , F_CONNECTION_UPGRADE = 1 << 3
- , F_TRAILING = 1 << 4
- , F_UPGRADE = 1 << 5
- , F_SKIPBODY = 1 << 6
+ , F_TRAILING = 1 << 3
+ , F_UPGRADE = 1 << 4
+ , F_SKIPBODY = 1 << 5
};
@@ -281,15 +271,13 @@ struct http_parser_url {
* unsigned major = (version >> 16) & 255;
* unsigned minor = (version >> 8) & 255;
* unsigned patch = version & 255;
- * printf("http_parser v%u.%u.%u\n", major, minor, patch);
+ * printf("http_parser v%u.%u.%u\n", major, minor, version);
*/
unsigned long http_parser_version(void);
void http_parser_init(http_parser *parser, enum http_parser_type type);
-/* Executes the parser. Returns number of parsed bytes. Sets
- * `parser->http_errno` on error. */
size_t http_parser_execute(http_parser *parser,
const http_parser_settings *settings,
const char *data,
diff --git a/deps/http_parser/test.c b/deps/http_parser/test.c
index 6c45d59d0c..9799dc6d34 100644
--- a/deps/http_parser/test.c
+++ b/deps/http_parser/test.c
@@ -950,42 +950,6 @@ const struct message requests[] =
,.body= ""
}
-#define CONNECTION_MULTI 35
-, {.name = "multiple connection header values with folding"
- ,.type= HTTP_REQUEST
- ,.raw= "GET /demo HTTP/1.1\r\n"
- "Host: example.com\r\n"
- "Connection: Something,\r\n"
- " Upgrade, ,Keep-Alive\r\n"
- "Sec-WebSocket-Key2: 12998 5 Y3 1 .P00\r\n"
- "Sec-WebSocket-Protocol: sample\r\n"
- "Upgrade: WebSocket\r\n"
- "Sec-WebSocket-Key1: 4 @1 46546xW%0l 1 5\r\n"
- "Origin: http://example.com\r\n"
- "\r\n"
- "Hot diggity dogg"
- ,.should_keep_alive= TRUE
- ,.message_complete_on_eof= FALSE
- ,.http_major= 1
- ,.http_minor= 1
- ,.method= HTTP_GET
- ,.query_string= ""
- ,.fragment= ""
- ,.request_path= "/demo"
- ,.request_url= "/demo"
- ,.num_headers= 7
- ,.upgrade="Hot diggity dogg"
- ,.headers= { { "Host", "example.com" }
- , { "Connection", "Something, Upgrade, ,Keep-Alive" }
- , { "Sec-WebSocket-Key2", "12998 5 Y3 1 .P00" }
- , { "Sec-WebSocket-Protocol", "sample" }
- , { "Upgrade", "WebSocket" }
- , { "Sec-WebSocket-Key1", "4 @1 46546xW%0l 1 5" }
- , { "Origin", "http://example.com" }
- }
- ,.body= ""
- }
-
, {.name= NULL } /* sentinel */
};
@@ -2243,6 +2207,7 @@ print_error (const char *raw, size_t error_location)
break;
case '\n':
+ char_len = 2;
fprintf(stderr, "\\n\n");
if (this_line) goto print;
@@ -2945,11 +2910,15 @@ test_simple (const char *buf, enum http_errno err_expected)
{
parser_init(HTTP_REQUEST);
+ size_t parsed;
+ int pass;
enum http_errno err;
- parse(buf, strlen(buf));
+ parsed = parse(buf, strlen(buf));
+ pass = (parsed == strlen(buf));
err = HTTP_PARSER_ERRNO(parser);
- parse(NULL, 0);
+ parsed = parse(NULL, 0);
+ pass &= (parsed == 0);
parser_free();
@@ -3507,13 +3476,6 @@ main (void)
test_simple(buf, HPE_INVALID_METHOD);
}
- // illegal header field name line folding
- test_simple("GET / HTTP/1.1\r\n"
- "name\r\n"
- " : value\r\n"
- "\r\n",
- HPE_INVALID_HEADER_TOKEN);
-
const char *dumbfuck2 =
"GET / HTTP/1.1\r\n"
"X-SSL-Bullshit: -----BEGIN CERTIFICATE-----\r\n"