diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-03-15 22:59:28 +0100 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2019-03-28 16:37:44 -0400 |
| commit | b7338b700fdc7927763840927c8acaf4963c0587 (patch) | |
| tree | c3380fdcceaf5f8c5647cc814993abd05eb03463 /deps | |
| parent | 02171949a02fb55adfeeaec90a3fc9be1c1d2bd3 (diff) | |
| download | android-node-v8-b7338b700fdc7927763840927c8acaf4963c0587.tar.gz android-node-v8-b7338b700fdc7927763840927c8acaf4963c0587.tar.bz2 android-node-v8-b7338b700fdc7927763840927c8acaf4963c0587.zip | |
deps: V8: cherry-pick f0bb5d2
Original commit message:
[api] remove LegacyBuildEmbedderGraphCallback
This should not be used anymore (and it definitely is not by Node.js
or Chromium).
Change-Id: I4a1ce1fda98efd197a64ce0969dae5c8b18f6e97
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511484
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60139}
Refs: https://github.com/v8/v8/commit/f0bb5d2fcf52cdc4147b0f17ab19f3d10d585f14
PR-URL: https://github.com/nodejs/node/pull/26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/include/v8-profiler.h | 8 | ||||
| -rw-r--r-- | deps/v8/src/api.cc | 10 |
2 files changed, 0 insertions, 18 deletions
diff --git a/deps/v8/include/v8-profiler.h b/deps/v8/include/v8-profiler.h index 3adce79be5..ada2dbbe5c 100644 --- a/deps/v8/include/v8-profiler.h +++ b/deps/v8/include/v8-profiler.h @@ -756,10 +756,6 @@ class V8_EXPORT HeapProfiler { v8::EmbedderGraph* graph, void* data); - /** TODO(addaleax): Remove */ - typedef void (*LegacyBuildEmbedderGraphCallback)(v8::Isolate* isolate, - v8::EmbedderGraph* graph); - /** Returns the number of snapshots taken. */ int GetSnapshotCount(); @@ -898,10 +894,6 @@ class V8_EXPORT HeapProfiler { */ void DeleteAllHeapSnapshots(); - V8_DEPRECATED( - "Use AddBuildEmbedderGraphCallback to provide info about embedder nodes", - void SetBuildEmbedderGraphCallback( - LegacyBuildEmbedderGraphCallback callback)); void AddBuildEmbedderGraphCallback(BuildEmbedderGraphCallback callback, void* data); void RemoveBuildEmbedderGraphCallback(BuildEmbedderGraphCallback callback, diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 716db0c85d..657c93419c 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -10443,16 +10443,6 @@ void HeapProfiler::DeleteAllHeapSnapshots() { reinterpret_cast<i::HeapProfiler*>(this)->DeleteAllSnapshots(); } -void HeapProfiler::SetBuildEmbedderGraphCallback( - LegacyBuildEmbedderGraphCallback callback) { - reinterpret_cast<i::HeapProfiler*>(this)->AddBuildEmbedderGraphCallback( - [](v8::Isolate* isolate, v8::EmbedderGraph* graph, void* data) { - reinterpret_cast<LegacyBuildEmbedderGraphCallback>(data)(isolate, - graph); - }, - reinterpret_cast<void*>(callback)); -} - void HeapProfiler::AddBuildEmbedderGraphCallback( BuildEmbedderGraphCallback callback, void* data) { reinterpret_cast<i::HeapProfiler*>(this)->AddBuildEmbedderGraphCallback( |