diff options
| author | Ali Ijaz Sheikh <ofrobots@google.com> | 2016-06-02 16:38:03 -0700 |
|---|---|---|
| committer | Michaël Zasso <mic.besace@gmail.com> | 2016-06-03 13:45:31 +0200 |
| commit | 8847777ab8be6792f31c2536a84e55a361612937 (patch) | |
| tree | 90862c57149c5874eedeb6f09d52c1215c01422b /deps | |
| parent | 8bccc9e6c82c558132a28a462e9dd573ae0302c6 (diff) | |
| download | android-node-v8-8847777ab8be6792f31c2536a84e55a361612937.tar.gz android-node-v8-8847777ab8be6792f31c2536a84e55a361612937.tar.bz2 android-node-v8-8847777ab8be6792f31c2536a84e55a361612937.zip | |
deps: update v8_inspector
Pick the latest v8_inspector [1] with:
* V8 5.1 compatibility
* Modify parse builder templates to make coverity happy
* The whitespace differences in the jinja2 sub-dependency do exist
upstream. I am not sure how I missed them in the original import
(ed2eac).
[1] https://github.com/pavelfeldman/v8_inspector/commit/3b56732
PR-URL: https://github.com/nodejs/node/pull/7118
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Diffstat (limited to 'deps')
3 files changed, 16 insertions, 3 deletions
diff --git a/deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py b/deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py index 5107feb680..62f77a783a 100644 --- a/deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py +++ b/deps/v8_inspector/platform/inspector_protocol/CodeGenerator.py @@ -180,6 +180,11 @@ def create_primitive_type_definition(type): "integer": "int", "boolean": "bool" } + defaults = { + "number": "0", + "integer": "0", + "boolean": "false" + } jsontypes = { "number": "TypeNumber", "integer": "TypeNumber", @@ -195,6 +200,7 @@ def create_primitive_type_definition(type): "raw_type": typedefs[type], "raw_pass_type": typedefs[type], "raw_return_type": typedefs[type], + "default_value": defaults[type] } type_definitions = {} diff --git a/deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template b/deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template index 75f6704328..144fcb149f 100644 --- a/deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template +++ b/deps/v8_inspector/platform/inspector_protocol/TypeBuilder_h.template @@ -187,7 +187,14 @@ public: } private: - {{type.id}}() { } + {{type.id}}() + { + {% for property in type.properties %} + {% if not(property.optional) and "default_value" in resolve_type(property) %} + m_{{property.name}} = {{resolve_type(property).default_value}}; + {%endif %} + {% endfor %} + } {% for property in type.properties %} {% if property.optional %} diff --git a/deps/v8_inspector/platform/v8_inspector/V8Compat.h b/deps/v8_inspector/platform/v8_inspector/V8Compat.h index 17d104f773..0f5b12cbb6 100644 --- a/deps/v8_inspector/platform/v8_inspector/V8Compat.h +++ b/deps/v8_inspector/platform/v8_inspector/V8Compat.h @@ -7,7 +7,7 @@ #include <v8.h> -#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2) +#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1) namespace v8 { // In standalone V8 inspector this is expected to be noop anyways... @@ -23,6 +23,6 @@ public: } // namespace v8 -#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2) +#endif // V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1) #endif // V8Compat_h |