diff options
| author | Refael Ackermann <refack@gmail.com> | 2019-03-13 17:55:15 -0400 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-03-14 18:51:01 +0100 |
| commit | 3531fe9320c0b98ce01238ee07812306e716c4bd (patch) | |
| tree | 365a71b948feb5200066404993daa4e7a3b1c335 /deps | |
| parent | 1c494b0a9500d4ec27330ff7ed55865112a5ee77 (diff) | |
| download | android-node-v8-3531fe9320c0b98ce01238ee07812306e716c4bd.tar.gz android-node-v8-3531fe9320c0b98ce01238ee07812306e716c4bd.tar.bz2 android-node-v8-3531fe9320c0b98ce01238ee07812306e716c4bd.zip | |
build,deps: add `NOMINMAX` to V8 Windows builds
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
PR-URL: https://github.com/nodejs/node/pull/25852
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/gypfiles/toolchain.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi index 10109024ba..eaac19592a 100644 --- a/deps/v8/gypfiles/toolchain.gypi +++ b/deps/v8/gypfiles/toolchain.gypi @@ -996,6 +996,7 @@ ['OS=="win"', { 'defines': [ 'WIN32', + 'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620 ], # 4351: VS 2005 and later are warning us that they've fixed a bug # present in VS 2003 and earlier. |