diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2019-09-14 09:20:31 +0530 |
|---|---|---|
| committer | Myles Borins <myles.borins@gmail.com> | 2019-10-07 03:20:11 -0400 |
| commit | 174723354ef6ad20e423c44b6d8af63ef7a0040c (patch) | |
| tree | 2694580b3a25cef7f32fa9e9756fc157f6511167 /deps/v8 | |
| parent | 5981fb7faa13de95550b01272ebfbd8a5220aadb (diff) | |
| download | android-node-v8-174723354ef6ad20e423c44b6d8af63ef7a0040c.tar.gz android-node-v8-174723354ef6ad20e423c44b6d8af63ef7a0040c.tar.bz2 android-node-v8-174723354ef6ad20e423c44b6d8af63ef7a0040c.zip | |
tools: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
PR-URL: https://github.com/nodejs/node/pull/29694
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'deps/v8')
| -rw-r--r-- | deps/v8/src/compiler/js-heap-broker.cc | 1 | ||||
| -rw-r--r-- | deps/v8/src/interpreter/interpreter.cc | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/deps/v8/src/compiler/js-heap-broker.cc b/deps/v8/src/compiler/js-heap-broker.cc index 7466a80f85..05048f7f4b 100644 --- a/deps/v8/src/compiler/js-heap-broker.cc +++ b/deps/v8/src/compiler/js-heap-broker.cc @@ -4115,6 +4115,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell, GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind) : ProcessedFeedback(kGlobalAccess, slot_kind), + cell_or_context_(base::nullopt), index_and_immutable_(0 /* doesn't matter */) { DCHECK(IsGlobalICKind(slot_kind)); } diff --git a/deps/v8/src/interpreter/interpreter.cc b/deps/v8/src/interpreter/interpreter.cc index 121971d305..482ffb7459 100644 --- a/deps/v8/src/interpreter/interpreter.cc +++ b/deps/v8/src/interpreter/interpreter.cc @@ -280,7 +280,7 @@ Interpreter::NewSourcePositionCollectionJob( auto job = base::make_unique<InterpreterCompilationJob>(parse_info, literal, allocator, nullptr); job->compilation_info()->SetBytecodeArray(existing_bytecode); - return job; + return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) }; } void Interpreter::ForEachBytecode( |