diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-03-15 22:57:44 +0100 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2019-03-28 16:37:11 -0400 |
| commit | 53ea813d5c0029d3ee90230054d5407a6864cb08 (patch) | |
| tree | e9d372bfdf4df505b1d6d65f14eb7014a95e65dc /deps/v8/test | |
| parent | cc75ba3f140c4584a776c163a365fedd4ea5ef63 (diff) | |
| download | android-node-v8-53ea813d5c0029d3ee90230054d5407a6864cb08.tar.gz android-node-v8-53ea813d5c0029d3ee90230054d5407a6864cb08.tar.bz2 android-node-v8-53ea813d5c0029d3ee90230054d5407a6864cb08.zip | |
deps: V8: cherry-pick 2f79d68
Original commit message:
Deprecate MicrotasksCompletedCallback in favor to use *WithData version
This adds overloads of v8::Isolate::{Add,Remove}MicrotaskCompletedCallback,
that use MicrotasksCompletedCallbackWithData, and marks the original one
as V8_DEPRECATE_SOON for transition.
Bug: v8:8124
Change-Id: I124c3108545e1a2b29cd95620f36901431663c65
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1493766
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60045}
Refs: https://github.com/v8/v8/commit/2f79d68664ba113b69f62c29ce85fd29dcf87df3
PR-URL: https://github.com/nodejs/node/pull/26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'deps/v8/test')
| -rw-r--r-- | deps/v8/test/cctest/test-api.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/deps/v8/test/cctest/test-api.cc b/deps/v8/test/cctest/test-api.cc index 9dfe1155d9..bd8180fb12 100644 --- a/deps/v8/test/cctest/test-api.cc +++ b/deps/v8/test/cctest/test-api.cc @@ -21680,12 +21680,10 @@ TEST(RunMicrotasksIgnoresThrownExceptionsFromApi) { uint8_t microtasks_completed_callback_count = 0; - -static void MicrotasksCompletedCallback(v8::Isolate* isolate) { +static void MicrotasksCompletedCallback(v8::Isolate* isolate, void*) { ++microtasks_completed_callback_count; } - TEST(SetAutorunMicrotasks) { LocalContext env; v8::HandleScope scope(env->GetIsolate()); |