diff options
author | Yang Guo <yangguo@chromium.org> | 2018-05-30 09:08:12 +0200 |
---|---|---|
committer | Yang Guo <yangguo@chromium.org> | 2018-06-07 20:35:40 +0200 |
commit | 8d27477acf59b7a15b2cf78c957e3fd1dc3245f5 (patch) | |
tree | 0de43ef216942b1058ae8e3a727a05b50248ecf1 /deps/v8/test/cctest | |
parent | 44d1a46a4277083803024eed2fb37d70c7d2bbcc (diff) | |
download | android-node-v8-8d27477acf59b7a15b2cf78c957e3fd1dc3245f5.tar.gz android-node-v8-8d27477acf59b7a15b2cf78c957e3fd1dc3245f5.tar.bz2 android-node-v8-8d27477acf59b7a15b2cf78c957e3fd1dc3245f5.zip |
deps: V8: cherry-pick a440efb27f from upstream
Original commit message:
[api] do not require source string for producing code cache.
The embedder should not need to keep track of the source string.
R=jgruber@chromium.org
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: Ie27df755a22fbcae7b6e87a435419d2d8f545558
Reviewed-on: https://chromium-review.googlesource.com/1013482
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52614}
PR-URL: https://github.com/nodejs/node/pull/21022
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Diffstat (limited to 'deps/v8/test/cctest')
-rw-r--r-- | deps/v8/test/cctest/test-api.cc | 3 | ||||
-rw-r--r-- | deps/v8/test/cctest/test-serialize.cc | 11 |
2 files changed, 6 insertions, 8 deletions
diff --git a/deps/v8/test/cctest/test-api.cc b/deps/v8/test/cctest/test-api.cc index 8b93944d93..4ebd93b86c 100644 --- a/deps/v8/test/cctest/test-api.cc +++ b/deps/v8/test/cctest/test-api.cc @@ -25485,8 +25485,7 @@ TEST(CodeCache) { v8::ScriptCompiler::kNoCompileOptions; v8::Local<v8::Script> script = v8::ScriptCompiler::Compile(context, &source, option).ToLocalChecked(); - cache = v8::ScriptCompiler::CreateCodeCache(script->GetUnboundScript(), - source_string); + cache = v8::ScriptCompiler::CreateCodeCache(script->GetUnboundScript()); } isolate1->Dispose(); diff --git a/deps/v8/test/cctest/test-serialize.cc b/deps/v8/test/cctest/test-serialize.cc index 370791f6c2..695bbbcfcb 100644 --- a/deps/v8/test/cctest/test-serialize.cc +++ b/deps/v8/test/cctest/test-serialize.cc @@ -1240,8 +1240,7 @@ static Handle<SharedFunctionInfo> CompileScriptAndProduceCache( NOT_NATIVES_CODE) .ToHandleChecked(); std::unique_ptr<ScriptCompiler::CachedData> cached_data( - ScriptCompiler::CreateCodeCache(ToApiHandle<UnboundScript>(sfi), - Utils::ToLocal(source))); + ScriptCompiler::CreateCodeCache(ToApiHandle<UnboundScript>(sfi))); uint8_t* buffer = NewArray<uint8_t>(cached_data->length); MemCopy(buffer, cached_data->data, cached_data->length); *script_data = new i::ScriptData(buffer, cached_data->length); @@ -1895,7 +1894,7 @@ v8::ScriptCompiler::CachedData* CompileRunAndProduceCache( .ToLocalChecked(); if (cacheType != CodeCacheType::kAfterExecute) { - cache = ScriptCompiler::CreateCodeCache(script, source_str); + cache = ScriptCompiler::CreateCodeCache(script); } v8::Local<v8::Value> result = script->BindToCurrentContext() @@ -1907,7 +1906,7 @@ v8::ScriptCompiler::CachedData* CompileRunAndProduceCache( .FromJust()); if (cacheType == CodeCacheType::kAfterExecute) { - cache = ScriptCompiler::CreateCodeCache(script, source_str); + cache = ScriptCompiler::CreateCodeCache(script); } CHECK(cache); } @@ -2153,7 +2152,7 @@ TEST(CodeSerializerWithHarmonyScoping) { v8::ScriptCompiler::CompileUnboundScript( isolate1, &source, v8::ScriptCompiler::kNoCompileOptions) .ToLocalChecked(); - cache = v8::ScriptCompiler::CreateCodeCache(script, source_str); + cache = v8::ScriptCompiler::CreateCodeCache(script); CHECK(cache); v8::Local<v8::Value> result = script->BindToCurrentContext() @@ -2218,7 +2217,7 @@ TEST(Regress503552) { heap::SimulateIncrementalMarking(isolate->heap()); v8::ScriptCompiler::CachedData* cache_data = - CodeSerializer::Serialize(shared, source); + CodeSerializer::Serialize(shared); delete cache_data; } |