diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-03-30 15:21:26 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-04-03 08:29:22 +0200 |
| commit | 2ea9de2e85d937c9bc5d778c623b22614c2b8a72 (patch) | |
| tree | 79a3248a0be08358e092342b33250adc8f936810 /deps/v8/src | |
| parent | 98b5ba840e00cea1614266745fa0ccf1e6211315 (diff) | |
| download | android-node-v8-2ea9de2e85d937c9bc5d778c623b22614c2b8a72.tar.gz android-node-v8-2ea9de2e85d937c9bc5d778c623b22614c2b8a72.tar.bz2 android-node-v8-2ea9de2e85d937c9bc5d778c623b22614c2b8a72.zip | |
deps: V8: cherry-pick f4b860d
Original commit message:
[heap,api] Remove deprecated APIs
Bug: chromium:923361, v8:8834
Change-Id: I6ec42aeb74bea5c0629fcdc3f95c125f5de534a0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526195
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60289}
Refs: https://github.com/v8/v8/commit/f4b860d9b81956fb9d6815932522f4043fef56fa
PR-URL: https://github.com/nodejs/node/pull/27013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'deps/v8/src')
| -rw-r--r-- | deps/v8/src/api.cc | 9 | ||||
| -rw-r--r-- | deps/v8/src/global-handles.cc | 10 | ||||
| -rw-r--r-- | deps/v8/src/global-handles.h | 3 |
3 files changed, 0 insertions, 22 deletions
diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 360bb78407..eae3fd2792 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -8876,15 +8876,6 @@ void Isolate::VisitHandlesWithClassIds(PersistentHandleVisitor* visitor) { isolate->global_handles()->IterateAllRootsWithClassIds(visitor); } - -void Isolate::VisitHandlesForPartialDependence( - PersistentHandleVisitor* visitor) { - i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this); - i::DisallowHeapAllocation no_allocation; - isolate->global_handles()->IterateAllYoungRootsWithClassIds(visitor); -} - - void Isolate::VisitWeakHandles(PersistentHandleVisitor* visitor) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this); i::DisallowHeapAllocation no_allocation; diff --git a/deps/v8/src/global-handles.cc b/deps/v8/src/global-handles.cc index 5eb3d93f14..350380b23c 100644 --- a/deps/v8/src/global-handles.cc +++ b/deps/v8/src/global-handles.cc @@ -379,7 +379,6 @@ class GlobalHandles::Node final : public NodeBase<GlobalHandles::Node> { Internals::kNodeStateMask); STATIC_ASSERT(WEAK == Internals::kNodeStateIsWeakValue); STATIC_ASSERT(PENDING == Internals::kNodeStateIsPendingValue); - STATIC_ASSERT(NEAR_DEATH == Internals::kNodeStateIsNearDeathValue); STATIC_ASSERT(static_cast<int>(IsIndependent::kShift) == Internals::kNodeIsIndependentShift); STATIC_ASSERT(static_cast<int>(IsActive::kShift) == @@ -427,11 +426,6 @@ class GlobalHandles::Node final : public NodeBase<GlobalHandles::Node> { flags_ = NodeWeaknessType::update(flags_, weakness_type); } - bool IsNearDeath() const { - // Check for PENDING to ensure correct answer when processing callbacks. - return state() == PENDING || state() == NEAR_DEATH; - } - bool IsWeak() const { return state() == WEAK; } bool IsInUse() const { return state() != FREE; } @@ -819,10 +813,6 @@ void GlobalHandles::AnnotateStrongRetainer(Address* location, Node::FromLocation(location)->AnnotateStrongRetainer(label); } -bool GlobalHandles::IsNearDeath(Address* location) { - return Node::FromLocation(location)->IsNearDeath(); -} - bool GlobalHandles::IsWeak(Address* location) { return Node::FromLocation(location)->IsWeak(); } diff --git a/deps/v8/src/global-handles.h b/deps/v8/src/global-handles.h index 3604af1d28..8caa3c33ce 100644 --- a/deps/v8/src/global-handles.h +++ b/deps/v8/src/global-handles.h @@ -73,9 +73,6 @@ class GlobalHandles final { // Clear the weakness of a global handle. static void* ClearWeakness(Address* location); - // Tells whether global handle is near death. - static bool IsNearDeath(Address* location); - // Tells whether global handle is weak. static bool IsWeak(Address* location); |