aboutsummaryrefslogtreecommitdiff
path: root/deps/v8/src/runtime
diff options
context:
space:
mode:
authorAli Ijaz Sheikh <ofrobots@google.com>2017-12-14 22:12:55 -0800
committerAli Ijaz Sheikh <ofrobots@google.com>2017-12-22 13:40:23 -0800
commitf454e14b223b87e2fcbefbb8b9398f438d8c12ce (patch)
tree6685ed66bfc30ab2f5529cbfe2f19ee1a93b83e8 /deps/v8/src/runtime
parentbbaea1236f9a788fcb3f76113dd0c3bae83a551b (diff)
downloadandroid-node-v8-f454e14b223b87e2fcbefbb8b9398f438d8c12ce.tar.gz
android-node-v8-f454e14b223b87e2fcbefbb8b9398f438d8c12ce.tar.bz2
android-node-v8-f454e14b223b87e2fcbefbb8b9398f438d8c12ce.zip
deps: V8: cherry-pick ac0fe8ec from upstream
Original commit message: [interpreter] Remove TryInstallOptimizedCode Removes the interrupt check and runtime call to TryInstallOptimizedCode from the optimization marker checks (i.e. CompileLazy and InterpreterEntryTrampoline). Instead, we rely on the other interrupt sources (in particular stack checks at function entries and loop headers) to install optimized code for us. This will hopefully not cause regressions, as we have plenty of other interrupt checks, but it may delay optimized code execution for some function by one function call. Bug: v8:6933 Change-Id: Ieadfff7ae2078d2a84085294158ad9a706eb9c64 Reviewed-on: https://chromium-review.googlesource.com/723475 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#48667} Ref: https://bugs.chromium.org/p/v8/issues/detail?id=6933 Ref: https://github.com/v8/v8/commit/ac0fe8ec8a13493aba5fd7fe55220d23cee62562 PR-URL: https://github.com/nodejs/node/pull/17695 Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps/v8/src/runtime')
-rw-r--r--deps/v8/src/runtime/runtime-compiler.cc21
-rw-r--r--deps/v8/src/runtime/runtime.h1
2 files changed, 0 insertions, 22 deletions
diff --git a/deps/v8/src/runtime/runtime-compiler.cc b/deps/v8/src/runtime/runtime-compiler.cc
index 1cc00f5b7e..b445037d08 100644
--- a/deps/v8/src/runtime/runtime-compiler.cc
+++ b/deps/v8/src/runtime/runtime-compiler.cc
@@ -302,27 +302,6 @@ RUNTIME_FUNCTION(Runtime_CompileForOnStackReplacement) {
return NULL;
}
-
-RUNTIME_FUNCTION(Runtime_TryInstallOptimizedCode) {
- HandleScope scope(isolate);
- DCHECK_EQ(1, args.length());
- CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0);
-
- // First check if this is a real stack overflow.
- StackLimitCheck check(isolate);
- if (check.JsHasOverflowed(kStackSpaceRequiredForCompilation * KB)) {
- return isolate->StackOverflow();
- }
-
- // Only try to install optimized functions if the interrupt was InstallCode.
- if (isolate->stack_guard()->CheckAndClearInstallCode()) {
- isolate->optimizing_compile_dispatcher()->InstallOptimizedFunctions();
- }
-
- return (function->IsOptimized()) ? function->code()
- : function->shared()->code();
-}
-
static Object* CompileGlobalEval(Isolate* isolate, Handle<String> source,
Handle<SharedFunctionInfo> outer_info,
LanguageMode language_mode,
diff --git a/deps/v8/src/runtime/runtime.h b/deps/v8/src/runtime/runtime.h
index e7084a8cca..a11d274d25 100644
--- a/deps/v8/src/runtime/runtime.h
+++ b/deps/v8/src/runtime/runtime.h
@@ -120,7 +120,6 @@ namespace internal {
F(NotifyStubFailure, 0, 1) \
F(NotifyDeoptimized, 0, 1) \
F(CompileForOnStackReplacement, 1, 1) \
- F(TryInstallOptimizedCode, 1, 1) \
F(ResolvePossiblyDirectEval, 6, 1) \
F(InstantiateAsmJs, 4, 1)