diff options
author | Myles Borins <mylesborins@google.com> | 2019-09-24 11:56:38 -0400 |
---|---|---|
committer | Myles Borins <myles.borins@gmail.com> | 2019-10-07 03:19:23 -0400 |
commit | f7f6c928c1c9c136b7926f892b8a2fda11d8b4b2 (patch) | |
tree | f5edbccb3ffda2573d70a6e291e7157f290e0ae0 /deps/v8/src/objects/string.cc | |
parent | ffd22e81983056d09c064c59343a0e488236272d (diff) | |
download | android-node-v8-f7f6c928c1c9c136b7926f892b8a2fda11d8b4b2.tar.gz android-node-v8-f7f6c928c1c9c136b7926f892b8a2fda11d8b4b2.tar.bz2 android-node-v8-f7f6c928c1c9c136b7926f892b8a2fda11d8b4b2.zip |
deps: update V8 to 7.8.279.9
PR-URL: https://github.com/nodejs/node/pull/29694
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'deps/v8/src/objects/string.cc')
-rw-r--r-- | deps/v8/src/objects/string.cc | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/deps/v8/src/objects/string.cc b/deps/v8/src/objects/string.cc index d1981fd24d..41de3aef04 100644 --- a/deps/v8/src/objects/string.cc +++ b/deps/v8/src/objects/string.cc @@ -110,6 +110,8 @@ void String::MakeThin(Isolate* isolate, String internalized) { } } + bool has_pointers = StringShape(*this).IsIndirect(); + int old_size = this->Size(); isolate->heap()->NotifyObjectLayoutChange(*this, old_size, no_gc); bool one_byte = internalized.IsOneByteRepresentation(); @@ -123,7 +125,9 @@ void String::MakeThin(Isolate* isolate, String internalized) { int size_delta = old_size - ThinString::kSize; if (size_delta != 0) { Heap* heap = isolate->heap(); - heap->CreateFillerObjectAt(thin_end, size_delta, ClearRecordedSlots::kNo); + heap->CreateFillerObjectAt( + thin_end, size_delta, + has_pointers ? ClearRecordedSlots::kYes : ClearRecordedSlots::kNo); } } @@ -178,7 +182,8 @@ bool String::MakeExternal(v8::String::ExternalStringResource* resource) { // Byte size of the external String object. int new_size = this->SizeFromMap(new_map); isolate->heap()->CreateFillerObjectAt( - this->address() + new_size, size - new_size, ClearRecordedSlots::kNo); + this->address() + new_size, size - new_size, + has_pointers ? ClearRecordedSlots::kYes : ClearRecordedSlots::kNo); if (has_pointers) { isolate->heap()->ClearRecordedSlotRange(this->address(), this->address() + new_size); @@ -250,7 +255,8 @@ bool String::MakeExternal(v8::String::ExternalOneByteStringResource* resource) { // Byte size of the external String object. int new_size = this->SizeFromMap(new_map); isolate->heap()->CreateFillerObjectAt( - this->address() + new_size, size - new_size, ClearRecordedSlots::kNo); + this->address() + new_size, size - new_size, + has_pointers ? ClearRecordedSlots::kYes : ClearRecordedSlots::kNo); if (has_pointers) { isolate->heap()->ClearRecordedSlotRange(this->address(), this->address() + new_size); |