diff options
author | Michaël Zasso <targos@protonmail.com> | 2018-09-07 17:07:13 +0200 |
---|---|---|
committer | Michaël Zasso <targos@protonmail.com> | 2018-09-07 20:59:13 +0200 |
commit | 586db2414a338e1bf6eaf6e672a3adc7ce309f6a (patch) | |
tree | 139fa972aef648481ddee22a3a85b99707d28df5 /deps/v8/src/objects/name-inl.h | |
parent | 12ed7c94e5160aa6d38e3d2cb2a73dae0a6f9342 (diff) | |
download | android-node-v8-586db2414a338e1bf6eaf6e672a3adc7ce309f6a.tar.gz android-node-v8-586db2414a338e1bf6eaf6e672a3adc7ce309f6a.tar.bz2 android-node-v8-586db2414a338e1bf6eaf6e672a3adc7ce309f6a.zip |
deps: update V8 to 6.9.427.22
PR-URL: https://github.com/nodejs/node/pull/21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'deps/v8/src/objects/name-inl.h')
-rw-r--r-- | deps/v8/src/objects/name-inl.h | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/deps/v8/src/objects/name-inl.h b/deps/v8/src/objects/name-inl.h index b4ebeb632b..e768a40ec2 100644 --- a/deps/v8/src/objects/name-inl.h +++ b/deps/v8/src/objects/name-inl.h @@ -25,8 +25,6 @@ BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit) BOOL_ACCESSORS(Symbol, flags, is_public, kPublicBit) BOOL_ACCESSORS(Symbol, flags, is_interesting_symbol, kInterestingSymbolBit) -TYPE_CHECKER(Symbol, SYMBOL_TYPE) - bool Symbol::is_private_field() const { bool value = BooleanBit::get(flags(), kPrivateFieldBit); DCHECK_IMPLIES(value, is_private()); @@ -71,13 +69,13 @@ bool Name::Equals(Name* other) { return String::cast(this)->SlowEquals(String::cast(other)); } -bool Name::Equals(Handle<Name> one, Handle<Name> two) { +bool Name::Equals(Isolate* isolate, Handle<Name> one, Handle<Name> two) { if (one.is_identical_to(two)) return true; if ((one->IsInternalizedString() && two->IsInternalizedString()) || one->IsSymbol() || two->IsSymbol()) { return false; } - return String::SlowEquals(Handle<String>::cast(one), + return String::SlowEquals(isolate, Handle<String>::cast(one), Handle<String>::cast(two)); } @@ -92,7 +90,10 @@ uint32_t Name::Hash() { uint32_t field = hash_field(); if (IsHashFieldComputed(field)) return field >> kHashShift; // Slow case: compute hash code and set it. Has to be a string. - return String::cast(this)->ComputeAndSetHash(); + // Also the string must be writable, because read-only strings will have their + // hash values precomputed. + return String::cast(this)->ComputeAndSetHash( + Heap::FromWritableHeapObject(this)->isolate()); } bool Name::IsInterestingSymbol() const { |