diff options
| author | Michaël Zasso <targos@protonmail.com> | 2018-09-21 09:14:51 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2018-09-22 18:29:25 +0200 |
| commit | 0e7ddbd3d7e9439c67573b854c49cf82c398ae82 (patch) | |
| tree | 2afe372acde921cb57ddb3444ff00c5adef8848c /deps/v8/src/inspector/v8-runtime-agent-impl.cc | |
| parent | 13245dc50da4cb7443c39ef6c68d419d5e6336d4 (diff) | |
| download | android-node-v8-0e7ddbd3d7e9439c67573b854c49cf82c398ae82.tar.gz android-node-v8-0e7ddbd3d7e9439c67573b854c49cf82c398ae82.tar.bz2 android-node-v8-0e7ddbd3d7e9439c67573b854c49cf82c398ae82.zip | |
deps: update V8 to 7.0.276.20
PR-URL: https://github.com/nodejs/node/pull/22754
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'deps/v8/src/inspector/v8-runtime-agent-impl.cc')
| -rw-r--r-- | deps/v8/src/inspector/v8-runtime-agent-impl.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/deps/v8/src/inspector/v8-runtime-agent-impl.cc b/deps/v8/src/inspector/v8-runtime-agent-impl.cc index 31111add16..d0ae633945 100644 --- a/deps/v8/src/inspector/v8-runtime-agent-impl.cc +++ b/deps/v8/src/inspector/v8-runtime-agent-impl.cc @@ -426,7 +426,8 @@ Response V8RuntimeAgentImpl::getProperties( if (!response.isSuccess()) return response; propertiesProtocolArray->addItem( InternalPropertyDescriptor::create() - .setName(toProtocolString(name.As<v8::String>())) + .setName( + toProtocolString(m_inspector->isolate(), name.As<v8::String>())) .setValue(std::move(wrappedValue)) .build()); } @@ -622,7 +623,8 @@ Response V8RuntimeAgentImpl::globalLexicalScopeNames( v8::debug::GlobalLexicalScopeNames(scope.context(), &names); *outNames = protocol::Array<String16>::create(); for (size_t i = 0; i < names.Size(); ++i) { - (*outNames)->addItem(toProtocolString(names.Get(i))); + (*outNames)->addItem( + toProtocolString(m_inspector->isolate(), names.Get(i))); } return Response::OK(); } @@ -690,8 +692,10 @@ void V8RuntimeAgentImpl::bindingCallback( int contextId = InspectedContext::contextId(isolate->GetCurrentContext()); int contextGroupId = inspector->contextGroupId(contextId); - String16 name = toProtocolString(v8::Local<v8::String>::Cast(info.Data())); - String16 payload = toProtocolString(v8::Local<v8::String>::Cast(info[0])); + String16 name = + toProtocolString(isolate, v8::Local<v8::String>::Cast(info.Data())); + String16 payload = + toProtocolString(isolate, v8::Local<v8::String>::Cast(info[0])); inspector->forEachSession( contextGroupId, |