diff options
author | Michaël Zasso <targos@protonmail.com> | 2018-09-21 09:14:51 +0200 |
---|---|---|
committer | Michaël Zasso <targos@protonmail.com> | 2018-09-22 18:29:25 +0200 |
commit | 0e7ddbd3d7e9439c67573b854c49cf82c398ae82 (patch) | |
tree | 2afe372acde921cb57ddb3444ff00c5adef8848c /deps/v8/src/inspector/injected-script-source.js | |
parent | 13245dc50da4cb7443c39ef6c68d419d5e6336d4 (diff) | |
download | android-node-v8-0e7ddbd3d7e9439c67573b854c49cf82c398ae82.tar.gz android-node-v8-0e7ddbd3d7e9439c67573b854c49cf82c398ae82.tar.bz2 android-node-v8-0e7ddbd3d7e9439c67573b854c49cf82c398ae82.zip |
deps: update V8 to 7.0.276.20
PR-URL: https://github.com/nodejs/node/pull/22754
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'deps/v8/src/inspector/injected-script-source.js')
-rw-r--r-- | deps/v8/src/inspector/injected-script-source.js | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/deps/v8/src/inspector/injected-script-source.js b/deps/v8/src/inspector/injected-script-source.js index 5e5302fbbe..ea0d871248 100644 --- a/deps/v8/src/inspector/injected-script-source.js +++ b/deps/v8/src/inspector/injected-script-source.js @@ -401,9 +401,12 @@ InjectedScript.prototype = { var isAccessorProperty = descriptor && ("get" in descriptor || "set" in descriptor); if (accessorPropertiesOnly && !isAccessorProperty) continue; - if (descriptor && "get" in descriptor && "set" in descriptor && name !== "__proto__" && + // Special case for Symbol.prototype.description where the receiver of the getter is not an actual object. + // Should only occur for nested previews. + var isSymbolDescription = isSymbol(object) && name === 'description'; + if (isSymbolDescription || (descriptor && "get" in descriptor && "set" in descriptor && name !== "__proto__" && InjectedScriptHost.formatAccessorsAsProperties(object, descriptor.get) && - !doesAttributeHaveObservableSideEffectOnGet(object, name)) { + !doesAttributeHaveObservableSideEffectOnGet(object, name))) { descriptor.value = object[property]; descriptor.isOwn = true; delete descriptor.get; @@ -594,6 +597,9 @@ InjectedScript.prototype = { return toString(obj); if (subtype === "node") { + // We should warmup blink dom binding before calling anything, + // see (crbug.com/827585) for details. + InjectedScriptHost.getOwnPropertyDescriptor(/** @type {!Object} */(obj), "nodeName"); var description = ""; var nodeName = InjectedScriptHost.getProperty(obj, "nodeName"); if (nodeName) { |