diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-03-15 22:59:50 +0100 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2019-03-28 16:37:58 -0400 |
commit | e6af2207a9d5a7602688379147662a2bb4ee4ce6 (patch) | |
tree | 6aa9fab00999f4af8addb81c79d5963cf3ccc951 /deps/v8/src/api.cc | |
parent | 963061bc024958cd424a75a507a0dbcf6724e2ec (diff) | |
download | android-node-v8-e6af2207a9d5a7602688379147662a2bb4ee4ce6.tar.gz android-node-v8-e6af2207a9d5a7602688379147662a2bb4ee4ce6.tar.bz2 android-node-v8-e6af2207a9d5a7602688379147662a2bb4ee4ce6.zip |
deps: V8: cherry-pick d5f08e4
Original commit message:
[api] Remove unowned Extensions interface
Extensions are now always passed via unique_ptr and are owned by V8.
This CL removes the deprecated API where the embedder would own the
Extension, but has no mechanism for deleting it.
R=ulan@chromium.org
Bug: v8:8725
Change-Id: Icb83660fad9d04c66f8db2265091ebabcbb197c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514493
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60186}
Refs: https://github.com/v8/v8/commit/d5f08e4e4fa5beedda1e22c2e16d8da99540574e
PR-URL: https://github.com/nodejs/node/pull/26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'deps/v8/src/api.cc')
-rw-r--r-- | deps/v8/src/api.cc | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 657c93419c..6742907a70 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -898,20 +898,10 @@ void V8::SetFlagsFromCommandLine(int* argc, char** argv, bool remove_flags) { RegisteredExtension* RegisteredExtension::first_extension_ = nullptr; -RegisteredExtension::RegisteredExtension(Extension* extension) - : legacy_unowned_extension_(extension) {} - RegisteredExtension::RegisteredExtension(std::unique_ptr<Extension> extension) : extension_(std::move(extension)) {} // static -void RegisteredExtension::Register(Extension* extension) { - RegisteredExtension* new_extension = new RegisteredExtension(extension); - new_extension->next_ = first_extension_; - first_extension_ = new_extension; -} - -// static void RegisteredExtension::Register(std::unique_ptr<Extension> extension) { RegisteredExtension* new_extension = new RegisteredExtension(std::move(extension)); @@ -946,8 +936,6 @@ class ExtensionResource : public String::ExternalOneByteStringResource { }; } // anonymous namespace -void RegisterExtension(Extension* that) { RegisteredExtension::Register(that); } - void RegisterExtension(std::unique_ptr<Extension> extension) { RegisteredExtension::Register(std::move(extension)); } |