diff options
author | Camillo Bruni <cbruni@chromium.org> | 2018-08-18 13:41:51 -0400 |
---|---|---|
committer | Timothy Gu <timothygu99@gmail.com> | 2018-08-23 23:09:16 -0400 |
commit | 349612b233a1af261991143b22e59461f075a987 (patch) | |
tree | 48a594796eff1bfa2a323363fcb887b451ed3abd /deps/v8/src/api.cc | |
parent | 2f9dabd0d84af8ed35feca3498116244cc41dad2 (diff) | |
download | android-node-v8-349612b233a1af261991143b22e59461f075a987.tar.gz android-node-v8-349612b233a1af261991143b22e59461f075a987.tar.bz2 android-node-v8-349612b233a1af261991143b22e59461f075a987.zip |
deps: cherry-pick e1a7699 from upstream V8
Original commit message:
[api][runtime] Support all-in ctors of {Named,Indexed}PropertyHandlerConfiguration
- Explicitly allows construction of
{Named,Indexed}PropertyHandlerConfiguration with all the members filled.
Bug: v8:7612
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I426ea33846b5dbf2b3482c722c963a6e4b0abded
Reviewed-on: https://chromium-review.googlesource.com/1163882
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55142}
PR-URL: https://github.com/nodejs/node/pull/22390
Fixes: https://github.com/nodejs/node/issues/17480
Fixes: https://github.com/nodejs/node/issues/17481
Refs: https://github.com/v8/v8/commit/e1a76995ef311eb3ca66e12ef1941ed596034d59
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps/v8/src/api.cc')
-rw-r--r-- | deps/v8/src/api.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 87b6b24270..fbd0dbc043 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -1811,10 +1811,6 @@ static i::Handle<i::InterceptorInfo> CreateInterceptorInfo( i::Isolate* isolate, Getter getter, Setter setter, Query query, Descriptor descriptor, Deleter remover, Enumerator enumerator, Definer definer, Local<Value> data, PropertyHandlerFlags flags) { - // Either intercept attributes or descriptor. - DCHECK(query == nullptr || descriptor == nullptr); - // Only use descriptor callback with definer callback. - DCHECK(query == nullptr || definer == nullptr); auto obj = i::Handle<i::InterceptorInfo>::cast( isolate->factory()->NewStruct(i::INTERCEPTOR_INFO_TYPE, i::TENURED)); obj->set_flags(0); |