summaryrefslogtreecommitdiff
path: root/deps/v8/include/v8.h
diff options
context:
space:
mode:
authorMichaël Zasso <targos@protonmail.com>2019-03-30 15:21:31 +0100
committerMichaël Zasso <targos@protonmail.com>2019-04-03 08:29:25 +0200
commit5b8434eebceb7a60062bbebc03cdf83d520c6bee (patch)
tree26a9a211a33a7d697431e197dc6c3d9e07cb7f44 /deps/v8/include/v8.h
parent8cc181c8eeb724d4ce0613fcc515857681bddbe9 (diff)
downloadandroid-node-v8-5b8434eebceb7a60062bbebc03cdf83d520c6bee.tar.gz
android-node-v8-5b8434eebceb7a60062bbebc03cdf83d520c6bee.tar.bz2
android-node-v8-5b8434eebceb7a60062bbebc03cdf83d520c6bee.zip
deps: V8: cherry-pick 0188634
Original commit message: [ptr-compr][ubsan] Use [Read/Write]UnalignedValue for unaligned fields When pointer compression is enabled the [u]intptr_t and double fields are only kTaggedSize aligned so in order to avoid undefined behavior in C++ code we have to access these values in an unaligned pointer friendly way although both x64 and arm64 architectures (where pointer compression is supported) allow unaligned access. These changes will be removed once v8:8875 is fixed and all the kSystemPointerSize fields are properly aligned. Bug: v8:7703 Change-Id: I4df477cbdeab806303bb4f675d52b61c06342c8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528996 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60321} Refs: https://github.com/v8/v8/commit/0188634ee523aef39ba71732b1ab9d422f449825 PR-URL: https://github.com/nodejs/node/pull/27013 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'deps/v8/include/v8.h')
-rw-r--r--deps/v8/include/v8.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h
index 7346e0bbbc..7e48cd422d 100644
--- a/deps/v8/include/v8.h
+++ b/deps/v8/include/v8.h
@@ -118,6 +118,7 @@ class Arguments;
class DeferredHandles;
class Heap;
class HeapObject;
+class ExternalString;
class Isolate;
class LocalEmbedderHeapTracer;
class MicrotaskQueue;
@@ -2797,7 +2798,7 @@ class V8_EXPORT String : public Name {
void operator=(const ExternalStringResourceBase&) = delete;
private:
- friend class internal::Heap;
+ friend class internal::ExternalString;
friend class v8::String;
friend class internal::ScopedExternalStringLock;
};