diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-03-04 13:27:08 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-03-14 18:50:10 +0100 |
| commit | cf649c9b0243612d4a75ad99c328c0feaed4c3b9 (patch) | |
| tree | a3e6024b24f9c865b3f2bb513e55cead671f4281 /deps/v8/AUTHORS | |
| parent | 44d5401b8d64161fb9d057c8ec47bbc917e87247 (diff) | |
| download | android-node-v8-cf649c9b0243612d4a75ad99c328c0feaed4c3b9.tar.gz android-node-v8-cf649c9b0243612d4a75ad99c328c0feaed4c3b9.tar.bz2 android-node-v8-cf649c9b0243612d4a75ad99c328c0feaed4c3b9.zip | |
deps: V8: cherry-pick 74571c8
Original commit message:
Fix preview of set entries
Set entries return an array with the value as first and second entry.
As such these are considered key value pairs to align with maps
entries iterator.
So far the return value was identical to the values iterator and that
is misleading.
This also adds tests to verify the results and improves the coverage
a tiny bit by testing different iterators.
Refs: https://github.com/nodejs/node/issues/24629
R=yangguo@chromium.org
Change-Id: I669a724bb4afaf5a713e468b1f51691d22c25253
Reviewed-on: https://chromium-review.googlesource.com/c/1350790
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59311}
Refs: https://github.com/v8/v8/commit/74571c80a945f2bdf4094a090410ae02b9a69af6
PR-URL: https://github.com/nodejs/node/pull/25852
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'deps/v8/AUTHORS')
| -rw-r--r-- | deps/v8/AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/deps/v8/AUTHORS b/deps/v8/AUTHORS index 7adf005528..baa3d09d36 100644 --- a/deps/v8/AUTHORS +++ b/deps/v8/AUTHORS @@ -148,6 +148,7 @@ Rick Waldron <waldron.rick@gmail.com> Rob Wu <rob@robwu.nl> Robert Mustacchi <rm@fingolfin.org> Robert Nagy <robert.nagy@gmail.com> +Ruben Bridgewater <ruben@bridgewater.de> Ryan Dahl <ry@tinyclouds.org> Sakthipriyan Vairamani (thefourtheye) <thechargingvolcano@gmail.com> Sander Mathijs van Veen <sander@leaningtech.com> |