diff options
| author | Benjamin <bencoe@gmail.com> | 2019-02-27 10:05:58 -0800 |
|---|---|---|
| committer | bcoe <bencoe@google.com> | 2019-03-05 09:48:20 -0800 |
| commit | c78788a0219cc950be7159e65b9e8db01e9c1a7a (patch) | |
| tree | a16c6c0a78673129bc8f81072dc4422d7872d0a4 /deps/v8/AUTHORS | |
| parent | d4fdec6b6593659cb38e1db9c8083d4fde9bcacb (diff) | |
| download | android-node-v8-c78788a0219cc950be7159e65b9e8db01e9c1a7a.tar.gz android-node-v8-c78788a0219cc950be7159e65b9e8db01e9c1a7a.tar.bz2 android-node-v8-c78788a0219cc950be7159e65b9e8db01e9c1a7a.zip | |
deps: v8, backport 2d08967
Original commit message:
[coverage] Extend SourceRangeAstVisitor for throw statements
The SourceRangeAstVisitor has custom logic for blocks ending with a
statement that has a continuation range. In these cases, the trailing
continuation is removed which makes the reported coverage ranges a bit
nicer.
throw Error('foo') consists of an ExpressionStatement, with a
Throw expression stored within the statement. The source range itself
is stored with the Throw, not the statement.
We now properly extract the correct AST node for trailing throw
statements.
R=jgruber@chromium.org, neis@chromium.org, yangguo@chromium.org
Bug: v8:8691
Change-Id: Ibcbab79fbe54719a8993045040349c863b139011
Reviewed-on: https://chromium-review.googlesource.com/c/1480632
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59936}
Refs: https://github.com/v8/v8/commit/2d08967d4a4b9a43aa2b11781421e09bff3b89ad
PR-URL: https://github.com/nodejs/node/pull/26413
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps/v8/AUTHORS')
| -rw-r--r-- | deps/v8/AUTHORS | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/deps/v8/AUTHORS b/deps/v8/AUTHORS index 241c69f046..50d5d1acef 100644 --- a/deps/v8/AUTHORS +++ b/deps/v8/AUTHORS @@ -50,7 +50,7 @@ Andrew Paprocki <andrew@ishiboo.com> Andrei Kashcha <anvaka@gmail.com> Anna Henningsen <anna@addaleax.net> Bangfu Tao <bangfu.tao@samsung.com> -Ben Coe <ben@npmjs.com> +Ben Coe <bencoe@gmail.com> Ben Newman <ben@meteor.com> Ben Noordhuis <info@bnoordhuis.nl> Benjamin Tan <demoneaux@gmail.com> |