diff options
author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2018-03-22 17:01:37 -0400 |
---|---|---|
committer | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2018-03-27 14:08:24 -0400 |
commit | 9e226475e8e28b8664643d6644503ccd06bceb9a (patch) | |
tree | 4bd59a699dfb90657664ccb8a7b073e076de6376 /deps/openssl/openssl | |
parent | 8eca6b8d3d3e2141180be62b75227f5dd0290a6b (diff) | |
download | android-node-v8-9e226475e8e28b8664643d6644503ccd06bceb9a.tar.gz android-node-v8-9e226475e8e28b8664643d6644503ccd06bceb9a.tar.bz2 android-node-v8-9e226475e8e28b8664643d6644503ccd06bceb9a.zip |
n-api: ensure in-module exceptions are propagated
Whenever we call into an addon, whether it is for a callback, for
module init, or for async work-related reasons, we should make sure
that
* the last error is cleared,
* the scopes before the call are the same as after, and
* if an exception was thrown and captured inside the module, then it is
re-thrown after the call.
Therefore we should call into the module in a unified fashion. This
change introduces the macro NAPI_CALL_INTO_MODULE() which should be
used whenever invoking a callback provided by the module.
Fixes: https://github.com/nodejs/node/issues/19437
PR-URL: https://github.com/nodejs/node/pull/19537
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'deps/openssl/openssl')
0 files changed, 0 insertions, 0 deletions