summaryrefslogtreecommitdiff
path: root/deps/npm/node_modules/lodash/lang/isMatch.js
diff options
context:
space:
mode:
authorJames Ide <ide@expo.io>2018-07-20 17:25:02 -0700
committerMichaël Zasso <targos@protonmail.com>2018-07-29 14:08:16 +0200
commit2aca0957f46af0be33368a1fcb398e63a35c46ef (patch)
treeb23ed8d5e018ead1556514abbd0a0bb023070bc0 /deps/npm/node_modules/lodash/lang/isMatch.js
parent8c6d1a06869a295cbcc835437bdc42ab15ac1e27 (diff)
downloadandroid-node-v8-2aca0957f46af0be33368a1fcb398e63a35c46ef.tar.gz
android-node-v8-2aca0957f46af0be33368a1fcb398e63a35c46ef.tar.bz2
android-node-v8-2aca0957f46af0be33368a1fcb398e63a35c46ef.zip
http2: release request()'s "connect" event listener after it runs
The `Http2Session#request()` method internally listens to the "connect" event if the session has not yet established a connection so that the actual request can be sent after the connection has been established. This commit removes the event listener after it runs and carries out the request and is no longer needed. In practice this shouldn't affect the behavior of the session object since the "connect" event fires only once anyway, but removing the listener releases its references. The rest of this class subscribes to the "connect" event with `once` instead of `on` as well. Tested by adding a new test that ensures `Http2Session#request()` is called before the connection is established, indicated by a "connect" listener that is run. The test also ensures all "connect" listeners are removed after the connection is established. PR-URL: https://github.com/nodejs/node/pull/21916 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'deps/npm/node_modules/lodash/lang/isMatch.js')
0 files changed, 0 insertions, 0 deletions