summaryrefslogtreecommitdiff
path: root/configure
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2018-04-26 09:03:26 +0200
committerRuben Bridgewater <ruben@bridgewater.de>2018-04-29 17:20:49 +0200
commita9051bb2c32f30dc6f715bed593765b257ba1a48 (patch)
tree606f7a976b11885bc91021de9bc29f10a448d651 /configure
parent541d2192cf0325f6b085a33828b40a0e5b23b76a (diff)
downloadandroid-node-v8-a9051bb2c32f30dc6f715bed593765b257ba1a48.tar.gz
android-node-v8-a9051bb2c32f30dc6f715bed593765b257ba1a48.tar.bz2
android-node-v8-a9051bb2c32f30dc6f715bed593765b257ba1a48.zip
build: remove --xcode configure switch
`./configure --xcode` ostensibly let you built with the Xcode IDE but it has never been tested regularly since its introduction in 2012 and probably has been broken for years. Remove it. PR-URL: https://github.com/nodejs/node/pull/20328 Fixes: https://github.com/nodejs/node/issues/20324 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure13
1 files changed, 1 insertions, 12 deletions
diff --git a/configure b/configure
index c1170f9a13..17e13a48d4 100755
--- a/configure
+++ b/configure
@@ -501,11 +501,6 @@ parser.add_option('--without-node-options',
dest='without_node_options',
help='build without NODE_OPTIONS support')
-parser.add_option('--xcode',
- action='store_true',
- dest='use_xcode',
- help='generate build files for use with xcode')
-
parser.add_option('--ninja',
action='store_true',
dest='use_ninja',
@@ -1005,9 +1000,6 @@ def configure_node(o):
o['variables']['asan'] = int(options.enable_asan or 0)
- if options.use_xcode and options.use_ninja:
- raise Exception('--xcode and --ninja cannot be used together.')
-
if options.coverage:
o['variables']['coverage'] = 'true'
else:
@@ -1530,7 +1522,6 @@ write('config.gypi', do_not_edit +
config = {
'BUILDTYPE': 'Debug' if options.debug else 'Release',
- 'USE_XCODE': str(int(options.use_xcode or 0)),
'PYTHON': sys.executable,
'NODE_TARGET_TYPE': variables['node_target_type'],
}
@@ -1549,9 +1540,7 @@ write('config.mk', do_not_edit + config)
gyp_args = ['--no-parallel']
-if options.use_xcode:
- gyp_args += ['-f', 'xcode']
-elif options.use_ninja:
+if options.use_ninja:
gyp_args += ['-f', 'ninja']
elif flavor == 'win' and sys.platform != 'msys':
gyp_args += ['-f', 'msvs', '-G', 'msvs_version=auto']