diff options
| author | Refael Ackermann <refack@gmail.com> | 2017-04-25 17:36:50 -0400 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2017-05-16 15:26:14 -0400 |
| commit | 4aff0563aa75f64adc6f6d4ef0965b3a14617d2b (patch) | |
| tree | cf605b394f682c3394e121b03f92e537d6354dcf /configure | |
| parent | 11918c4aedd27c0ed6b5f029fb2a50c889530db5 (diff) | |
| download | android-node-v8-4aff0563aa75f64adc6f6d4ef0965b3a14617d2b.tar.gz android-node-v8-4aff0563aa75f64adc6f6d4ef0965b3a14617d2b.tar.bz2 android-node-v8-4aff0563aa75f64adc6f6d4ef0965b3a14617d2b.zip | |
build: reduce one level of spawning in node_gyp
`configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug
PR-URL: https://github.com/nodejs/node/pull/12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'configure')
| -rwxr-xr-x | configure | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -40,6 +40,7 @@ import nodedownload # imports in tools/ sys.path.insert(0, os.path.join(root_dir, 'tools')) import getmoduleversion +from gyp_node import run_gyp # parse our options parser = optparse.OptionParser() @@ -1380,7 +1381,7 @@ config = '\n'.join(map('='.join, config.iteritems())) + '\n' write('config.mk', do_not_edit + config) -gyp_args = [sys.executable, 'tools/gyp_node.py', '--no-parallel'] +gyp_args = ['--no-parallel'] if options.use_xcode: gyp_args += ['-f', 'xcode'] @@ -1399,4 +1400,4 @@ gyp_args += args if warn.warned: warn('warnings were emitted in the configure phase') -sys.exit(subprocess.call(gyp_args)) +run_gyp(gyp_args) |