diff options
author | Evandro Oliveira <evandrofranco@gmail.com> | 2018-04-29 03:49:21 -0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-06-08 01:31:57 +0200 |
commit | 214ff0a9d5848cca202ea3590fc667a5b0c9fa4e (patch) | |
tree | 1a888aa6ec1a96ea5b332321029bf851aba1efc2 /configure | |
parent | 32c51f10d33c686f2607559ff24a97d6c4a6f109 (diff) | |
download | android-node-v8-214ff0a9d5848cca202ea3590fc667a5b0c9fa4e.tar.gz android-node-v8-214ff0a9d5848cca202ea3590fc667a5b0c9fa4e.tar.bz2 android-node-v8-214ff0a9d5848cca202ea3590fc667a5b0c9fa4e.zip |
build: fix 'gas_version' check on localized environments
Some GNU assembler versions got localized outputs like...
```
Gnu assembler versão 2.30 (x86_64-linux-gnu) usando versão BFD (GNU Binutils for Ubuntu) 2.30
```
failing regex checker and the whole configure process.
PR-URL: https://github.com/nodejs/node/pull/20394
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure')
-rwxr-xr-x | configure | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -671,11 +671,13 @@ def get_xcode_version(cc): def get_gas_version(cc): try: + custom_env = os.environ.copy() + custom_env["LC_ALL"] = "en_US" proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o', '/dev/null', '-x', 'assembler', '/dev/null'], stdin=subprocess.PIPE, stderr=subprocess.PIPE, - stdout=subprocess.PIPE) + stdout=subprocess.PIPE, env=custom_env) except OSError: error('''No acceptable C compiler found! |