summaryrefslogtreecommitdiff
path: root/configure.py
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-12-20 14:33:29 +0100
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-12-21 07:28:45 +0100
commitb5784fe5d598c9c8076cacaad7105a05457b22b4 (patch)
tree7144179cf4d7568d03e0c5bf721c007b4d57976d /configure.py
parenta9812142ca4116b425e92274c437d99e1d713fe2 (diff)
downloadandroid-node-v8-b5784fe5d598c9c8076cacaad7105a05457b22b4.tar.gz
android-node-v8-b5784fe5d598c9c8076cacaad7105a05457b22b4.tar.bz2
android-node-v8-b5784fe5d598c9c8076cacaad7105a05457b22b4.zip
deps: V8: backport bf84766
Original commit message: [CloneObjectIC] clone MutableHeapNumbers instead of referencing them Adds a helper macro "CloneIfMutablePrimitive", which tests if the operand is a MutableHeapNumber, and if so, clones it, otherwise returning the original value. Also modifies the signature of "CopyPropertyArrayValues" to take a "DestroySource" enum, indicating whether or not the resulting object is supplanting the source object or not, and removes all default parameters from that macro (which were not used anyways). This corrects the issue reported in chromium:901301, where StaNamedOwnProperty was replacing the value of a MutableHeapNumber referenced by both the cloned object and the source object. BUG=chromium:901301, v8:7611 R=cbruni@chromium.org, jkummerow@chromium.org Change-Id: I43df1ddc84dfa4840e680b6affeba452ce0b6629 Reviewed-on: https://chromium-review.googlesource.com/c/1318096 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57304} PR-URL: https://github.com/nodejs/node/pull/25101 Refs: https://github.com/v8/v8/commit/bf84766a2cd3e09070adcd6228a3a487c8dc4bbd Fixes: https://github.com/nodejs/node/issues/25089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Yang Guo <yangguo@chromium.org>
Diffstat (limited to 'configure.py')
0 files changed, 0 insertions, 0 deletions