summaryrefslogtreecommitdiff
path: root/configure.py
diff options
context:
space:
mode:
authorRichard Lau <riclau@uk.ibm.com>2019-03-31 14:22:58 -0400
committerRichard Lau <riclau@uk.ibm.com>2019-04-03 18:55:37 -0400
commitb180a1572768a16d14c08d1f847e2b8aa7afe87c (patch)
treedeceb871dc4365f567edd130fda33f2177e2ef0d /configure.py
parent15c0947fee2078bae4af1404e64448bf959a53bb (diff)
downloadandroid-node-v8-b180a1572768a16d14c08d1f847e2b8aa7afe87c.tar.gz
android-node-v8-b180a1572768a16d14c08d1f847e2b8aa7afe87c.tar.bz2
android-node-v8-b180a1572768a16d14c08d1f847e2b8aa7afe87c.zip
build: only emit download ICU warnings once
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: https://github.com/nodejs/node/issues/26860 PR-URL: https://github.com/nodejs/node/pull/27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'configure.py')
-rwxr-xr-xconfigure.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/configure.py b/configure.py
index 6d184f5655..c23af24873 100755
--- a/configure.py
+++ b/configure.py
@@ -1253,13 +1253,14 @@ def configure_intl(o):
if not os.access(options.download_path, os.W_OK):
error('''Cannot write to desired download path.
Either create it or verify permissions.''')
+ attemptdownload = nodedownload.candownload(auto_downloads, "icu")
for icu in icus:
url = icu['url']
md5 = icu['md5']
local = url.split('/')[-1]
targetfile = os.path.join(options.download_path, local)
if not os.path.isfile(targetfile):
- if nodedownload.candownload(auto_downloads, "icu"):
+ if attemptdownload:
nodedownload.retrievefile(url, targetfile)
else:
print('Re-using existing %s' % targetfile)