diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-11-26 13:03:22 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-12-03 17:30:30 +0800 |
| commit | 6fd289860190f80b616fdb126bb97ce3f8a0a1c7 (patch) | |
| tree | e423b347d2a851b8409c2ca356d8822dbc96be9f /configure.py | |
| parent | cc3f2b386c6ee34f5574c69c29647165a9bc3aef (diff) | |
| download | android-node-v8-6fd289860190f80b616fdb126bb97ce3f8a0a1c7.tar.gz android-node-v8-6fd289860190f80b616fdb126bb97ce3f8a0a1c7.tar.bz2 android-node-v8-6fd289860190f80b616fdb126bb97ce3f8a0a1c7.zip | |
build: add --without-node-code-cache configure option
So that it's possible to build without code cache (in particular,
without building mkcodecache) for testing.
PR-URL: https://github.com/nodejs/node/pull/30647
Refs: https://github.com/nodejs/node/issues/28845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/configure.py b/configure.py index 959c1db651..61708a4447 100755 --- a/configure.py +++ b/configure.py @@ -455,6 +455,11 @@ parser.add_option('--without-node-snapshot', dest='without_node_snapshot', help='Turn off V8 snapshot integration. Currently experimental.') +parser.add_option('--without-node-code-cache', + action='store_true', + dest='without_node_code_cache', + help='Turn off V8 Code cache integration.') + intl_optgroup.add_option('--download', action='store', dest='download_list', @@ -980,6 +985,12 @@ def configure_node(o): else: o['variables']['node_use_node_snapshot'] = 'false' + if not options.without_node_code_cache: + # TODO(refack): fix this when implementing embedded code-cache when cross-compiling. + o['variables']['node_use_node_code_cache'] = b(not cross_compiling) + else: + o['variables']['node_use_node_code_cache'] = 'false' + if target_arch == 'arm': configure_arm(o) elif target_arch in ('mips', 'mipsel', 'mips64el'): @@ -1100,9 +1111,7 @@ def configure_node(o): o['variables']['debug_nghttp2'] = 'false' o['variables']['node_no_browser_globals'] = b(options.no_browser_globals) - # TODO(refack): fix this when implementing embedded code-cache when cross-compiling. - if o['variables']['want_separate_host_toolset'] == 0: - o['variables']['node_code_cache'] = 'yes' # For testing + o['variables']['node_shared'] = b(options.shared) node_module_version = getmoduleversion.get_version() |