diff options
author | Richard Lau <riclau@uk.ibm.com> | 2019-10-18 13:31:50 -0400 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-22 13:44:05 -0500 |
commit | 639085e410e805303b4511edee4c2a315006a7f8 (patch) | |
tree | 071a6e4681f94bcf85001ebe4b0af2f12ef91eff /configure.py | |
parent | 0ecd3c68452ff9b9709cdaf5b11b48e36c685a8e (diff) | |
download | android-node-v8-639085e410e805303b4511edee4c2a315006a7f8.tar.gz android-node-v8-639085e410e805303b4511edee4c2a315006a7f8.tar.bz2 android-node-v8-639085e410e805303b4511edee4c2a315006a7f8.zip |
build: log the found compiler version if too old
`configure` will log a warning if the detected compiler is not new
enough. Take some of the guesswork out of it by also logging the
version of the compiler that was detected.
PR-URL: https://github.com/nodejs/node/pull/30028
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'configure.py')
-rwxr-xr-x | configure.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/configure.py b/configure.py index f1badfdb93..bfc50d7fbd 100755 --- a/configure.py +++ b/configure.py @@ -775,7 +775,8 @@ def check_compiler(o): if not ok: warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX) elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0): - warn('C++ compiler too old, need g++ 6.3.0 or clang++ 8.0.0 (CXX=%s)' % CXX) + warn('C++ compiler (CXX=%s, %s) too old, need g++ 6.3.0 or clang++ 8.0.0' % + (CXX, ".".join(map(str, clang_version if is_clang else gcc_version)))) ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c') if not ok: @@ -784,7 +785,8 @@ def check_compiler(o): # clang 3.2 is a little white lie because any clang version will probably # do for the C bits. However, we might as well encourage people to upgrade # to a version that is not completely ancient. - warn('C compiler too old, need gcc 4.2 or clang 3.2 (CC=%s)' % CC) + warn('C compiler (CC=%s, %s) too old, need gcc 4.2 or clang 3.2' % + (CC, ".".join(map(str, gcc_version)))) o['variables']['llvm_version'] = get_llvm_version(CC) if is_clang else '0.0' |