diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-10-21 16:07:44 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-08 15:50:50 +0100 |
| commit | d56f9a9b86b051c64709e80b6ec0e34198de4890 (patch) | |
| tree | b38c51100c059ce3f945074d5c83c9a7d9f9b805 /common.gypi | |
| parent | d751952c48325563cbdcd7d263db9ba112f3acc9 (diff) | |
| download | android-node-v8-d56f9a9b86b051c64709e80b6ec0e34198de4890.tar.gz android-node-v8-d56f9a9b86b051c64709e80b6ec0e34198de4890.tar.bz2 android-node-v8-d56f9a9b86b051c64709e80b6ec0e34198de4890.zip | |
deps: V8: cherry-pick cfe9172
Original commit message:
[wasm] Disallow interpreter move
The MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR macro defines a defaulted move
constructor and move-assignment operator. The {std::unique_ptr} on the
other hand needs the contained type to be complete when instantiating
the move assignment operator. Hence, this fails e.g. on MSVC, see
https://github.com/nodejs/node/pull/30020#issuecomment-544485991.
It turns out that we never actually move the interpreter, so we can
just replace the MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR by
DISALLOW_COPY_AND_ASSIGN.
R=ahaas@chromium.org
Change-Id: Iba7d30243510ed9554be62b0c4c8e6f47f0c3307
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871921
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64423}
Refs: https://github.com/v8/v8/commit/cfe9172e64795a69112f8247bdcc00954ca9515e
PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 4119517dbb..5ea3e36506 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### |