diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-10-22 15:07:21 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-10-26 16:22:37 -0700 |
| commit | d29f0eda152b0407bf6bd1e63f548bd39cd2fcd3 (patch) | |
| tree | 600150647f177f6d8b2b37edf8b38bcf13cf5d44 /common.gypi | |
| parent | 7b2de22d72a5fef171d835560a975615a938eaf3 (diff) | |
| download | android-node-v8-d29f0eda152b0407bf6bd1e63f548bd39cd2fcd3.tar.gz android-node-v8-d29f0eda152b0407bf6bd1e63f548bd39cd2fcd3.tar.bz2 android-node-v8-d29f0eda152b0407bf6bd1e63f548bd39cd2fcd3.zip | |
deps: V8: backport 777fa98
Original commit message:
Make SetSyntheticModuleExport throw instead of crash for nonexistent export name
Per spec, Module::SetSyntheticModuleExport should throw a ReferenceError
when called with an export name that was not supplied when constructing
that SyntheticModule. Instead, the current implementation crashes with
a failed CHECK().
Add a new Module::SyntheticModuleSetExport that throws (without an ensuing
crash) for this case, and deprecate the old
Module::SetSyntheticModuleExport.
Bug: v8:9828
Change-Id: I3b3d353064c3851882781818099bd8f6ee74c809
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1860996
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#64438}
Refs: https://github.com/v8/v8/commit/777fa98cc47ac32f0fde3d9aafd830949deb5d23
PR-URL: https://github.com/nodejs/node/pull/30062
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 44e41a9753..e6b189f957 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.16', + 'v8_embedder_string': '-node.17', ##### V8 defaults for Node.js ##### |